| Message ID | 20231016-dt-net-cleanups-v1-6-a525a090b444@kernel.org |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: net: Child node schema cleanups | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17.10.2023 00:44, Rob Herring wrote: > The indentation for the example is completely messed up for > 'ethernet-ports'. Fix it. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/net/mscc,vsc7514-switch.yaml | 32 +++++++++++----------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > index 8ee2c7d7ff42..07de52a3a295 100644 > --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > @@ -185,7 +185,7 @@ examples: > }; > # VSC7512 (DSA) > - | > - ethernet-switch@1{ > + ethernet-switch@1 { > compatible = "mscc,vsc7512-switch"; > reg = <0x71010000 0x10000>, > <0x71030000 0x10000>, > @@ -212,22 +212,22 @@ examples: > "port7", "port8", "port9", "port10", "qsys", > "ana", "s0", "s1", "s2"; > > - ethernet-ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - ethernet = <&mac_sw>; > - phy-handle = <&phy0>; > - phy-mode = "internal"; > - }; > - port@1 { > - reg = <1>; > - phy-handle = <&phy1>; > - phy-mode = "internal"; > - }; > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + ethernet = <&mac_sw>; > + phy-handle = <&phy0>; > + phy-mode = "internal"; > + }; Could use 4-space indentation as described here. https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html#example-schema Regardless: Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com> Arınç
On Mon, Oct 16, 2023 at 04:44:25PM -0500, Rob Herring wrote: > The indentation for the example is completely messed up for > 'ethernet-ports'. Fix it. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml index 8ee2c7d7ff42..07de52a3a295 100644 --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml @@ -185,7 +185,7 @@ examples: }; # VSC7512 (DSA) - | - ethernet-switch@1{ + ethernet-switch@1 { compatible = "mscc,vsc7512-switch"; reg = <0x71010000 0x10000>, <0x71030000 0x10000>, @@ -212,22 +212,22 @@ examples: "port7", "port8", "port9", "port10", "qsys", "ana", "s0", "s1", "s2"; - ethernet-ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - ethernet = <&mac_sw>; - phy-handle = <&phy0>; - phy-mode = "internal"; - }; - port@1 { - reg = <1>; - phy-handle = <&phy1>; - phy-mode = "internal"; - }; + ethernet-ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + ethernet = <&mac_sw>; + phy-handle = <&phy0>; + phy-mode = "internal"; + }; + port@1 { + reg = <1>; + phy-handle = <&phy1>; + phy-mode = "internal"; }; }; + }; ...
The indentation for the example is completely messed up for 'ethernet-ports'. Fix it. Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/net/mscc,vsc7514-switch.yaml | 32 +++++++++++----------- 1 file changed, 16 insertions(+), 16 deletions(-)