| Message ID | 20231011002146.1821-15-quic_wcheng@quicinc.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce QC USB SND audio offloading support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Tue, 10 Oct 2023 17:21:26 -0700, Wesley Cheng wrote: > Ensure that the number of XHCI secondary interrupters defined for a DWC3 > based implementation is limited to 8. XHCI in general can potentially > support up to 1024 interrupters. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml: num-hc-interrupters: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231011002146.1821-15-quic_wcheng@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Oct 10, 2023 at 09:31:04PM -0500, Rob Herring wrote: > > On Tue, 10 Oct 2023 17:21:26 -0700, Wesley Cheng wrote: > > Ensure that the number of XHCI secondary interrupters defined for a DWC3 > > based implementation is limited to 8. XHCI in general can potentially > > support up to 1024 interrupters. > > > > Reviewed-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml: num-hc-interrupters: missing type definition Patch 15 should come first. Rob
diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index d81c2e849ca9..3e9141e8a005 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -433,6 +433,10 @@ properties: items: enum: [1, 4, 8, 16, 32, 64, 128, 256] + num-hc-interrupters: + maximum: 8 + default: 1 + port: $ref: /schemas/graph.yaml#/properties/port description: