diff mbox series

[v2] dt-bindings: nvmem: mxs-ocotp: Document fsl,ocotp

Message ID 20231010171442.3693843-1-festevam@gmail.com
State Not Applicable
Headers show
Series [v2] dt-bindings: nvmem: mxs-ocotp: Document fsl,ocotp | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 22 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Oct. 10, 2023, 5:14 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Both imx23.dtsi and imx28.dtsi describe the OCOTP nodes in
the format:

compatible = "fsl,imx28-ocotp", "fsl,ocotp";

Document the "fsl,ocotp" entry to fix the following schema
warning:

efuse@8002c000: compatible: ['fsl,imx23-ocotp', 'fsl,ocotp'] is too long
from schema $id: http://devicetree.org/schemas/nvmem/mxs-ocotp.yaml#

Fixes: 2c504460f502 ("dt-bindings: nvmem: Convert MXS OCOTP to json-schema")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Added Fixes tag. (Conor)

 Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Conor Dooley Oct. 11, 2023, 3:42 p.m. UTC | #1 
On Tue, Oct 10, 2023 at 02:14:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Both imx23.dtsi and imx28.dtsi describe the OCOTP nodes in
> the format:
> 
> compatible = "fsl,imx28-ocotp", "fsl,ocotp";
> 
> Document the "fsl,ocotp" entry to fix the following schema
> warning:
> 
> efuse@8002c000: compatible: ['fsl,imx23-ocotp', 'fsl,ocotp'] is too long
> from schema $id: http://devicetree.org/schemas/nvmem/mxs-ocotp.yaml#
> 
> Fixes: 2c504460f502 ("dt-bindings: nvmem: Convert MXS OCOTP to json-schema")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> Changes since v1:
> - Added Fixes tag. (Conor)
> 
>  Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> index f43186f98607..d9287be89877 100644
> --- a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> @@ -15,9 +15,11 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fsl,imx23-ocotp
> -      - fsl,imx28-ocotp
> +    items:
> +      - enum:
> +          - fsl,imx23-ocotp
> +          - fsl,imx28-ocotp
> +      - const: fsl,ocotp
>  
>    reg:
>      maxItems: 1
> @@ -35,7 +37,7 @@ unevaluatedProperties: false
>  examples:
>    - |
>      ocotp: efuse@8002c000 {
> -        compatible = "fsl,imx28-ocotp";
> +        compatible = "fsl,imx28-ocotp", "fsl,ocotp";
>          #address-cells = <1>;
>          #size-cells = <1>;
>          reg = <0x8002c000 0x2000>;
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
index f43186f98607..d9287be89877 100644
--- a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
+++ b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
@@ -15,9 +15,11 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx23-ocotp
-      - fsl,imx28-ocotp
+    items:
+      - enum:
+          - fsl,imx23-ocotp
+          - fsl,imx28-ocotp
+      - const: fsl,ocotp
 
   reg:
     maxItems: 1
@@ -35,7 +37,7 @@  unevaluatedProperties: false
 examples:
   - |
     ocotp: efuse@8002c000 {
-        compatible = "fsl,imx28-ocotp";
+        compatible = "fsl,imx28-ocotp", "fsl,ocotp";
         #address-cells = <1>;
         #size-cells = <1>;
         reg = <0x8002c000 0x2000>;