| Message ID | 20231004121010.1192344-1-naresh.solanki@9elements.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/3] dt-bindings: regulator: regulator-output: Multiple supplies | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 04/10/2023 14:10, Naresh Solanki wrote: > Add support for multiple supplies. > Nothing improved here. Why? BTW, for regulator please use subject with reversed prefixes. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Best regards, Krzysztof
On Wed, Oct 04, 2023 at 02:10:07PM +0200, Naresh Solanki wrote: > Add support for multiple supplies. Again, why? > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > --- > .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > index 078b37a1a71a..6d077f123729 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml > +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml > @@ -21,13 +21,13 @@ properties: > compatible: > const: regulator-output > > - vout-supply: > +patternProperties: > + ".*-supply": > description: > Phandle of the regulator supplying the output. > > required: > - compatible > - - vout-supply > > additionalProperties: false > > @@ -37,3 +37,8 @@ examples: > compatible = "regulator-output"; > vout-supply = <&output_reg>; > }; > + output1 { > + compatible = "regulator-output"; > + sw0-supply = <&output_reg0>; > + sw1-supply = <&output_reg2>; > + }; > > base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026 > -- > 2.41.0 >
On Fri, Oct 06, 2023 at 11:30:54AM -0500, Rob Herring wrote: > On Wed, Oct 04, 2023 at 02:10:07PM +0200, Naresh Solanki wrote: > > Add support for multiple supplies. > Again, why? FWIW I do tend to share the same question that Rob and other people have asked a few times here - is this really one userspace consumer with multiple supplies, if so what does that userspace consumer represent? I'd be expecting that this was representing a single supply to an external device which for the most part would have a single input supply.
diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml index 078b37a1a71a..6d077f123729 100644 --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml @@ -21,13 +21,13 @@ properties: compatible: const: regulator-output - vout-supply: +patternProperties: + ".*-supply": description: Phandle of the regulator supplying the output. required: - compatible - - vout-supply additionalProperties: false @@ -37,3 +37,8 @@ examples: compatible = "regulator-output"; vout-supply = <&output_reg>; }; + output1 { + compatible = "regulator-output"; + sw0-supply = <&output_reg0>; + sw1-supply = <&output_reg2>; + };
Add support for multiple supplies. Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> --- .../devicetree/bindings/regulator/regulator-output.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) base-commit: f9a1d31874c383f58bb4f89bfe79b764682cd026