| Message ID | 20231003133440.4696-3-karelb@gimli.ms.mff.cuni.cz |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | input/touchscreen: imagis: add support for IST3032C | expand |
| Context | Check | Description |
|---|---|---|
| robh/dt-meta-schema | success | |
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
On 03/10/2023 15:34, karelb@gimli.ms.mff.cuni.cz wrote: > From: Karel Balej <karelb@gimli.ms.mff.cuni.cz> > > From: Markuss Broks <markuss.broks@gmail.com> This does not look right. Please apply it to your tree and see the result. You cannot have two From fields, > > Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC, > add the compatible for it to the IST3038C bindings. > > Signed-off-by: Markuss Broks <markuss.broks@gmail.com> > Signed-off-by: Karel Balej <balejk@matfyz.cz> Best regards, Krzysztof
Hello, Krzysztof, On Wed Oct 4, 2023 at 10:09 AM CEST, Krzysztof Kozlowski wrote: > On 03/10/2023 15:34, karelb@gimli.ms.mff.cuni.cz wrote: > > From: Karel Balej <karelb@gimli.ms.mff.cuni.cz> > > > > From: Markuss Broks <markuss.broks@gmail.com> > > This does not look right. Please apply it to your tree and see the > result. You cannot have two From fields, I am aware of this problem and I have explained it in a follow-up message to the cover-letter, which should have reached you too - was it not so? The patches themselves should be fine though, so I plan to wait for some feedback and fix this either in v3 or in a resend before application. Best regards, K. B.
diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml index 0d6b033fd5fb..b5372c4eae56 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml @@ -18,6 +18,7 @@ properties: compatible: enum: + - imagis,ist3038b - imagis,ist3038c reg: