diff mbox series

dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas

Message ID 20230926164529.102427-1-robh@kernel.org
State Not Applicable
Headers show
Series dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Rob Herring (Arm) Sept. 26, 2023, 4:45 p.m. UTC
Just as unevaluatedProperties or additionalProperties are required at
the top level of schemas, they should (and will) also be required for
child node schemas. That ensures only documented properties are
present for any node.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley Sept. 27, 2023, 3:11 p.m. UTC | #1
On Tue, Sep 26, 2023 at 11:45:25AM -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>



Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Rafał Miłecki Sept. 28, 2023, 10:43 a.m. UTC | #2
On 2023-09-26 18:45, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks!

Acked-by: Rafał Miłecki <rafal@milecki.pl>
Srinivas Kandagatla Oct. 7, 2023, 10:23 a.m. UTC | #3
On Tue, 26 Sep 2023 11:45:25 -0500, Rob Herring wrote:
> Just as unevaluatedProperties or additionalProperties are required at
> the top level of schemas, they should (and will) also be required for
> child node schemas. That ensures only documented properties are
> present for any node.
> 
> 

Applied, thanks!

[1/1] dt-bindings: nvmem: u-boot,env: Add missing additionalProperties on child node schemas
      commit: 8beb2ec54b65eb08891c9b9c23428712d46d8e15

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
index 36d97fb87865..9c36afc7084b 100644
--- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
+++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
@@ -51,6 +51,8 @@  properties:
   ethaddr:
     type: object
     description: Ethernet interfaces base MAC address.
+    additionalProperties: false
+
     properties:
       "#nvmem-cell-cells":
         description: The first argument is a MAC address offset.