diff mbox series

[v2,1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

Message ID 20230926102821.306860-1-festevam@gmail.com
State Superseded
Headers show
Series [v2,1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 26, 2023, 10:28 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware
used for connecting, disconnecting and switching orientation of
the SBU lines in USB Type-C applications.

CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
Changes since v1:
- None. Only collected Conor's Ack.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Jun Li Sept. 27, 2023, 3:11 a.m. UTC | #1 
> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Tuesday, September 26, 2023 6:28 PM
> To: shawnguo@kernel.org
> Cc: gregkh@linuxfoundation.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> dl-linux-imx <linux-imx@nxp.com>; Fabio Estevam <festevam@denx.de>
> Subject: [PATCH v2 3/3] arm64: dts: imx8qxp-mek: Pass gpio-sbu-mux
> mode-switch
> 
> From: Fabio Estevam <festevam@denx.de>
> 
> Per gpio-sbu-mux.yaml, the 'mode-switch' property is mandatory.
> 
> Pass it to fix the following schema warning:
> 
> imx8qxp-mek.dtb: gpio-sbu-mux: 'mode-switch' is a required property
> 	from schema $id:
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice
> tree.org%2Fschemas%2Fusb%2Fgpio-sbu-mux.yaml%23&data=05%7C01%7Cjun.li%4
> 0nxp.com%7C81075d4568d24477088408dbbe7b67f5%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638313209472999434%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7
> C&sdata=GfQ15vL%2BIQoX9u8tFW60aO%2FrGDLEOBfQoKqP%2FN7tHXY%3D&reserved=0
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - None.
> 
>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index a06a6491ef20..f95b58c69c6a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -36,6 +36,7 @@ gpio-sbu-mux {
>  		pinctrl-0 = <&pinctrl_typec_mux>;
>  		select-gpios = <&lsio_gpio5 9 GPIO_ACTIVE_HIGH>;
>  		enable-gpios = <&pca9557_a 7 GPIO_ACTIVE_LOW>;
> +		mode-switch;

mode-switch:
    description: Flag the port as possible handle of altmode switching
    type: boolean

I don't think there is altmode enabled on iMX8QXP MEK board, there is
only an orientation switch.

Li Jun

>  		orientation-switch;
> 
>  		port {
> --
> 2.34.1
Fabio Estevam Sept. 27, 2023, 12:03 p.m. UTC | #2 
Hi Li Jun,

On Wed, Sep 27, 2023 at 12:11 AM Jun Li <jun.li@nxp.com> wrote:

> mode-switch:
>     description: Flag the port as possible handle of altmode switching
>     type: boolean
>
> I don't think there is altmode enabled on iMX8QXP MEK board, there is
> only an orientation switch.

Okay, so I will send a change that removes mode-switch from the
required properties list then.

Thanks
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
index f196beb826d8..b61dcf8b4aad 100644
--- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
+++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
@@ -19,6 +19,7 @@  properties:
   compatible:
     items:
       - enum:
+          - nxp,cbdtu02043
           - onnn,fsusb43l10x
           - pericom,pi3usb102
       - const: gpio-sbu-mux