diff mbox series

dt-bindings: gpio: fsl-imx-gpio: Document imx25 and imx27

Message ID 20230924161403.698833-1-festevam@gmail.com
State Superseded
Headers show
Series dt-bindings: gpio: fsl-imx-gpio: Document imx25 and imx27 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 24, 2023, 4:14 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

fsl,imx25-gpio and fsl,imx27-gpio are not documented, causing schema
warnings.

fsl,imx25-gpio is compatible with fsl,imx35-gpio and fsl,imx27-gpio
is compatible with fsl,imx21-gpio.

Document them accordingly.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Krzysztof Kozlowski Sept. 25, 2023, 7:07 a.m. UTC | #1 
On 24/09/2023 18:14, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> fsl,imx25-gpio and fsl,imx27-gpio are not documented, causing schema
> warnings.
> 
> fsl,imx25-gpio is compatible with fsl,imx35-gpio and fsl,imx27-gpio
> is compatible with fsl,imx21-gpio.
> 
> Document them accordingly.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> index d0ca2af89f1e..e716c6170643 100644
> --- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
> @@ -21,6 +21,14 @@ properties:
>        - items:
>            - const: fsl,imx35-gpio
>            - const: fsl,imx31-gpio
> +      - items:
> +          - enum:
> +              - fsl,imx25-gpio
> +          - const: fsl,imx35-gpio
> +      - items:
> +          - enum:
> +              - fsl,imx27-gpio
> +          - const: fsl,imx21-gpio

This does not look like placed in ordered way (order is by fallback
compatible).

>        - items:
>            - enum:
>                - fsl,imx50-gpio

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
index d0ca2af89f1e..e716c6170643 100644
--- a/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml
@@ -21,6 +21,14 @@  properties:
       - items:
           - const: fsl,imx35-gpio
           - const: fsl,imx31-gpio
+      - items:
+          - enum:
+              - fsl,imx25-gpio
+          - const: fsl,imx35-gpio
+      - items:
+          - enum:
+              - fsl,imx27-gpio
+          - const: fsl,imx21-gpio
       - items:
           - enum:
               - fsl,imx50-gpio