diff mbox series

dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false'

Message ID 20230923192619.601890-1-festevam@gmail.com
State Not Applicable
Headers show
Series dt-bindings: i2c: mxs: Pass ref and 'unevaluatedProperties: false' | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 17 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 23, 2023, 7:26 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
several schema warnings such as:
 
imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#

Fix these warnings by passing a reference to i2c-controller.yaml#
and using 'unevaluatedProperties: false' just like the yaml bindings
of other I2C controllers.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/i2c/i2c-mxs.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 23, 2023, 7:30 p.m. UTC | #1 
On 23/09/2023 21:26, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
> several schema warnings such as:
>  
> imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#
> 
> Fix these warnings by passing a reference to i2c-controller.yaml#
> and using 'unevaluatedProperties: false' just like the yaml bindings
> of other I2C controllers.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Wolfram Sang Sept. 25, 2023, 6:21 a.m. UTC | #2 
On Sat, Sep 23, 2023 at 04:26:19PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Running 'make dtbs_check DT_SCHEMA_FILES=i2c-mxs.yaml' throws
> several schema warnings such as:
>  
> imx28-m28evk.dtb: i2c@80058000: '#address-cells', '#size-cells', 'codec@a', 'eeprom@51', 'rtc@68' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/i2c/i2c-mxs.yaml#
> 
> Fix these warnings by passing a reference to i2c-controller.yaml#
> and using 'unevaluatedProperties: false' just like the yaml bindings
> of other I2C controllers.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied to for-current, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
index 21ae7bce038e..171a41407241 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mxs.yaml
@@ -9,6 +9,9 @@  title: Freescale MXS Inter IC (I2C) Controller
 maintainers:
   - Shawn Guo <shawnguo@kernel.org>
 
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
 properties:
   compatible:
     enum:
@@ -37,7 +40,7 @@  required:
   - dmas
   - dma-names
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |