diff mbox series

[v2,1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm

Message ID 20230922124229.359543-1-festevam@gmail.com
State Not Applicable
Headers show
Series [v2,1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 22, 2023, 12:42 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

imx28 uses the same PWM block that is found on imx23.

Add an entry for fsl,imx28-pwm.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Changes since v1:
- None. Only collected Uwe's ack.

 Documentation/devicetree/bindings/pwm/mxs-pwm.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Uwe Kleine-König Sept. 23, 2023, 9:05 p.m. UTC | #1 
Hello Fabio,

On Fri, Sep 22, 2023 at 09:42:29AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> mxs-pwm.yaml documents that #pwm-cells should be 3.
> 
> This is correct as the last cell may indicate the PWM polarity.
> 
> Convert all mxs devicetree files to using #pwm-cells = <3> for
> consistency.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Very nice,

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks!
Uwe
Shawn Guo Sept. 25, 2023, 3:52 a.m. UTC | #2 
On Fri, Sep 22, 2023 at 09:42:29AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> mxs-pwm.yaml documents that #pwm-cells should be 3.
> 
> This is correct as the last cell may indicate the PWM polarity.
> 
> Convert all mxs devicetree files to using #pwm-cells = <3> for
> consistency.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
Rob Herring (Arm) Sept. 25, 2023, 4:16 p.m. UTC | #3 
On Fri, 22 Sep 2023 09:42:27 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> imx28 uses the same PWM block that is found on imx23.
> 
> Add an entry for fsl,imx28-pwm.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Changes since v1:
> - None. Only collected Uwe's ack.
> 
>  Documentation/devicetree/bindings/pwm/mxs-pwm.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Thierry Reding Oct. 6, 2023, 8:45 a.m. UTC | #4 
On Fri, 22 Sep 2023 09:42:27 -0300, Fabio Estevam wrote:
> imx28 uses the same PWM block that is found on imx23.
> 
> Add an entry for fsl,imx28-pwm.
> 
> 

Applied, thanks!

[1/3] dt-bindings: pwm: mxs: Document fsl,imx28-pwm
      commit: c3c653422a265a3b5dfdf8567eebd5116311c36d
[2/3] dt-bindings: pwm: mxs: Document the clocks property
      commit: 42b9116ce12579692ec18ad9446ea5ad832ea0ef

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
index 6ffbed204c25..655f008081d5 100644
--- a/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/mxs-pwm.yaml
@@ -15,8 +15,12 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - fsl,imx23-pwm
+    oneOf:
+      - const: fsl,imx23-pwm
+      - items:
+          - enum:
+              - fsl,imx28-pwm
+          - const: fsl,imx23-pwm
 
   reg:
     maxItems: 1