diff mbox series

[v3,3/3] ASoC: dt-bindings: wlf,wm8782: Add wlf,fsampen property

Message ID 20230917173726.1916439-4-contact@jookia.org
State Superseded
Headers show
Series ASoC: wm8782: Allow higher audio rates | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success

Commit Message

John Watts Sept. 17, 2023, 5:37 p.m. UTC
The WM8782 can safely support rates higher than 48kHz by changing the
value of the FSAMPEN pin.

Allow specifying the FSAMPEN pin value in the device tree.

Signed-off-by: John Watts <contact@jookia.org>
---
 Documentation/devicetree/bindings/sound/wm8782.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

John Watts Sept. 17, 2023, 5:46 p.m. UTC | #1
On Mon, Sep 18, 2023 at 03:37:26AM +1000, John Watts wrote:
> +Optional properties:
> +
> + - wlf,fsampen : FSAMPEN pin value, 0 for low, 1 for high, 2 for disconnected
> +

Uh-oh, I forgot to specify what it defaults to.
Should I reply to this patch with a fix or re-send the entire series after I get feedback?

John.
Charles Keepax Sept. 18, 2023, 8:35 a.m. UTC | #2
On Mon, Sep 18, 2023 at 03:46:06AM +1000, John Watts wrote:
> On Mon, Sep 18, 2023 at 03:37:26AM +1000, John Watts wrote:
> > +Optional properties:
> > +
> > + - wlf,fsampen : FSAMPEN pin value, 0 for low, 1 for high, 2 for disconnected
> > +
> 
> Uh-oh, I forgot to specify what it defaults to.
> Should I reply to this patch with a fix or re-send the entire series after I get feedback?
> 

I would probably send a new spin with the fix and my acks.

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/wm8782.txt b/Documentation/devicetree/bindings/sound/wm8782.txt
index 256cdec6ec4d..d217a616e103 100644
--- a/Documentation/devicetree/bindings/sound/wm8782.txt
+++ b/Documentation/devicetree/bindings/sound/wm8782.txt
@@ -8,10 +8,15 @@  Required properties:
  - Vdda-supply : phandle to a regulator for the analog power supply (2.7V - 5.5V)
  - Vdd-supply  : phandle to a regulator for the digital power supply (2.7V - 3.6V)
 
+Optional properties:
+
+ - wlf,fsampen : FSAMPEN pin value, 0 for low, 1 for high, 2 for disconnected
+
 Example:
 
 wm8782: stereo-adc {
 	compatible = "wlf,wm8782";
 	Vdda-supply = <&vdda_supply>;
 	Vdd-supply = <&vdd_supply>;
+	wlf,fsampen = <2>; /* 192KHz */
 };