| Message ID | 20230912163810.1750488-1-festevam@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3,1/3] dt-bindings: imx8-jpeg: Add clocks entries | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 39 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Tue, Sep 12, 2023 at 1:38 PM Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <festevam@denx.de> > > Per nxp,imx8-jpeg.yaml, the clock-names entry is not valid. > > Remove them. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Sorry, I missed adding imx8-ss-img in the Subject line.
On 12/09/2023 18:38, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need > the PER and IPG clocks to be functional, so add the clock entries. > > This also fixes the following schema warning: > > imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v2: > - Remove clock-names. (Mirela) > > .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..3383a275c94a 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -31,6 +31,9 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 2 You need to describe the clocks, so "items" with descriptions instead of maxItems. Best regards, Krzysztof
On 13/09/2023 09:04, Krzysztof Kozlowski wrote: > On 12/09/2023 18:38, Fabio Estevam wrote: >> From: Fabio Estevam <festevam@denx.de> >> >> The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need >> the PER and IPG clocks to be functional, so add the clock entries. >> >> This also fixes the following schema warning: >> >> imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml# >> >> Signed-off-by: Fabio Estevam <festevam@denx.de> >> --- >> Changes since v2: >> - Remove clock-names. (Mirela) >> >> .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> index 3d9d1db37040..3383a275c94a 100644 >> --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml >> @@ -31,6 +31,9 @@ properties: >> reg: >> maxItems: 1 >> >> + clocks: >> + maxItems: 2 > > You need to describe the clocks, so "items" with descriptions instead of > maxItems. And to be clear: such description was in your previous version, so it's the problem introduced now in v3... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index 3d9d1db37040..3383a275c94a 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml @@ -31,6 +31,9 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 2 + interrupts: description: | There are 4 slots available in the IP, which the driver may use @@ -49,6 +52,7 @@ properties: required: - compatible - reg + - clocks - interrupts - power-domains @@ -56,12 +60,15 @@ additionalProperties: false examples: - | + #include <dt-bindings/clock/imx8-lpcg.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/firmware/imx/rsrc.h> jpegdec: jpegdec@58400000 { compatible = "nxp,imx8qxp-jpgdec"; reg = <0x58400000 0x00050000 >; + clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>, + <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>; interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, @@ -76,6 +83,8 @@ examples: jpegenc: jpegenc@58450000 { compatible = "nxp,imx8qm-jpgenc", "nxp,imx8qxp-jpgenc"; reg = <0x58450000 0x00050000 >; + clocks = <&img_jpeg_enc_lpcg IMX_LPCG_CLK_0>, + <&img_jpeg__lpcg IMX_LPCG_CLK_4>; interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,