| Message ID | 20230912140613.6528-1-macpaul.lin@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] dt-bindings: arm64: dts: mediatek: add mt8390-evk board | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 12/09/2023 16:06, Macpaul Lin wrote: > 1. Add compatible for MT8390. > 2. Add bindings for the MediaTek mt8390-evk board, also known > as the "Genio 700-EVK". > > The MT8390 and MT8188 belong to the same SoC family, > with only minor differences in their physical characteristics. > They utilize unique efuse values for differentiation. > > The booting process and configurations are managed by boot > loaders, firmware, and TF-A. Consequently, the part numbers > and procurement channels vary. > > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > dependencies for v1: > - This patch should be applied after the following patch set > - mt8365's bindings > - https://lore.kernel.org/linux-arm-kernel/20230912092444.31635-1-macpaul.lin@mediatek.com/T/ > - mt8395's bindings > - https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/ > - mt8188's bindings > - https://lore.kernel.org/lkml/a4e1a80ebd19896410f50b0297e05dce06fb47cc.camel@mediatek.com/T/ > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index d8e449c6a7d7..047204a4aff5 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -251,6 +251,12 @@ properties: > - items: > - const: mediatek,mt8365-evk > - const: mediatek,mt8365 > + - description: MediaTek Genio 700 Boards (Genio 700 EVK) We had a long discussion, so again: drop description. Best regards, Krzysztof
On 12/09/2023 16:06, Macpaul Lin wrote: > Add basic device-tree for the Genio 700 EVK board. The > Genio 700 EVK is based on MediaTek MT8390 SoC. > MT8390 hardware register maps are identical to MT8188. > > The Genio 700 EVK has following features: > ... > + > + sdio_fixed_1v8: regulator-3 { > + compatible = "regulator-fixed"; > + regulator-name = "sdio_io"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + enable-active-high; > + regulator-always-on; > + }; > + > + sdio_fixed_3v3: regulator-4 { > + compatible = "regulator-fixed"; > + regulator-name = "sdio_card"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 74 0>; Use proper defines. > + enable-active-high; > + regulator-always-on; > + }; > + > + touch0_fixed_3v3: regulator-5 { > + compatible = "regulator-fixed"; > + regulator-name = "touch_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 119 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + usb_hub_fixed_3v3: regulator-6 { > + compatible = "regulator-fixed"; > + regulator-name = "usb_hub_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 112 0>; /* HUB_3V3_EN */ > + startup-delay-us = <10000>; > + enable-active-high; > + }; > + > + usb_hub_reset_1v8: regulator-7 { > + compatible = "regulator-fixed"; > + regulator-name = "usb_hub_reset"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + gpio = <&pio 7 0>; /* HUB_RESET */ > + vin-supply = <&usb_hub_fixed_3v3>; > + }; > + > + usb_p0_vbus: regulator-8 { > + compatible = "regulator-fixed"; > + regulator-name = "usb_p0_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 84 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + usb_p1_vbus: regulator-9 { > + compatible = "regulator-fixed"; > + regulator-name = "usb_p1_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + gpio = <&pio 87 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + usb_p2_vbus: regulator-10 { > + compatible = "regulator-fixed"; > + regulator-name = "usb_p2_vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + enable-active-high; > + }; > +}; > + > +&i2c0 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c0_pins>; > + clock-frequency = <400000>; > + status = "okay"; > + > + touchscreen@5d { > + compatible = "goodix,gt9271"; > + reg = <0x5d>; > + interrupt-parent = <&pio>; > + interrupts = <6 IRQ_TYPE_EDGE_RISING>; > + irq-gpios = <&pio 6 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>; > + AVDD28-supply = <&touch0_fixed_3v3>; > + VDDIO-supply = <&mt6359_vio18_ldo_reg>; > + pinctrl-names = "default"; > + pinctrl-0 = <&touch_pins>; > + }; > +}; > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + clock-frequency = <400000>; > + status = "okay"; > +}; > + > +&i2c2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c2_pins>; > + clock-frequency = <400000>; > + status = "okay"; > +}; > + > +&i2c3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c3_pins>; > + clock-frequency = <400000>; > + status = "okay"; > +}; > + > +&i2c4 { > + pinctrl-names = "default", "default"; Why do you need two default entries? This should be just one, shouldn't it? Best regards, Krzysztof
On 9/12/23 22:31, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 12/09/2023 16:06, Macpaul Lin wrote: >> 1. Add compatible for MT8390. >> 2. Add bindings for the MediaTek mt8390-evk board, also known >> as the "Genio 700-EVK". >> >> The MT8390 and MT8188 belong to the same SoC family, >> with only minor differences in their physical characteristics. >> They utilize unique efuse values for differentiation. >> >> The booting process and configurations are managed by boot >> loaders, firmware, and TF-A. Consequently, the part numbers >> and procurement channels vary. >> >> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >> --- >> Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> dependencies for v1: >> - This patch should be applied after the following patch set >> - mt8365's bindings >> - https://lore.kernel.org/linux-arm-kernel/20230912092444.31635-1-macpaul.lin@mediatek.com/T/ >> - mt8395's bindings >> - https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/ >> - mt8188's bindings >> - https://lore.kernel.org/lkml/a4e1a80ebd19896410f50b0297e05dce06fb47cc.camel@mediatek.com/T/ >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >> index d8e449c6a7d7..047204a4aff5 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >> @@ -251,6 +251,12 @@ properties: >> - items: >> - const: mediatek,mt8365-evk >> - const: mediatek,mt8365 >> + - description: MediaTek Genio 700 Boards (Genio 700 EVK) > > We had a long discussion, so again: drop description. > Okay, will drop description and send v2 series. > Best regards, > Krzysztof Thanks Macpaul Lin
On 9/12/23 22:32, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 12/09/2023 16:06, Macpaul Lin wrote: >> Add basic device-tree for the Genio 700 EVK board. The >> Genio 700 EVK is based on MediaTek MT8390 SoC. >> MT8390 hardware register maps are identical to MT8188. >> >> The Genio 700 EVK has following features: >> > > > ... > >> + >> +sdio_fixed_1v8: regulator-3 { >> +compatible = "regulator-fixed"; >> +regulator-name = "sdio_io"; >> +regulator-min-microvolt = <1800000>; >> +regulator-max-microvolt = <1800000>; >> +enable-active-high; >> +regulator-always-on; >> +}; >> + >> +sdio_fixed_3v3: regulator-4 { >> +compatible = "regulator-fixed"; >> +regulator-name = "sdio_card"; >> +regulator-min-microvolt = <3300000>; >> +regulator-max-microvolt = <3300000>; >> +gpio = <&pio 74 0>; > > Use proper defines. Fixed remaining 3 defines of gpio value, will send v2. >> +enable-active-high; >> +regulator-always-on; >> +}; >> + >> +touch0_fixed_3v3: regulator-5 { >> +compatible = "regulator-fixed"; >> +regulator-name = "touch_3v3"; >> +regulator-min-microvolt = <3300000>; >> +regulator-max-microvolt = <3300000>; >> +gpio = <&pio 119 GPIO_ACTIVE_HIGH>; >> +enable-active-high; >> +}; >> + >> +usb_hub_fixed_3v3: regulator-6 { >> +compatible = "regulator-fixed"; >> +regulator-name = "usb_hub_3v3"; >> +regulator-min-microvolt = <3300000>; >> +regulator-max-microvolt = <3300000>; >> +gpio = <&pio 112 0>; /* HUB_3V3_EN */ >> +startup-delay-us = <10000>; >> +enable-active-high; >> +}; >> + >> +usb_hub_reset_1v8: regulator-7 { >> +compatible = "regulator-fixed"; >> +regulator-name = "usb_hub_reset"; >> +regulator-min-microvolt = <1800000>; >> +regulator-max-microvolt = <1800000>; >> +gpio = <&pio 7 0>; /* HUB_RESET */ >> +vin-supply = <&usb_hub_fixed_3v3>; >> +}; >> + >> +usb_p0_vbus: regulator-8 { >> +compatible = "regulator-fixed"; >> +regulator-name = "usb_p0_vbus"; >> +regulator-min-microvolt = <5000000>; >> +regulator-max-microvolt = <5000000>; >> +gpio = <&pio 84 GPIO_ACTIVE_HIGH>; >> +enable-active-high; >> +}; >> + >> +usb_p1_vbus: regulator-9 { >> +compatible = "regulator-fixed"; >> +regulator-name = "usb_p1_vbus"; >> +regulator-min-microvolt = <5000000>; >> +regulator-max-microvolt = <5000000>; >> +gpio = <&pio 87 GPIO_ACTIVE_HIGH>; >> +enable-active-high; >> +}; >> + >> +usb_p2_vbus: regulator-10 { >> +compatible = "regulator-fixed"; >> +regulator-name = "usb_p2_vbus"; >> +regulator-min-microvolt = <5000000>; >> +regulator-max-microvolt = <5000000>; >> +enable-active-high; >> +}; >> +}; >> + >> +&i2c0 { >> +pinctrl-names = "default"; >> +pinctrl-0 = <&i2c0_pins>; >> +clock-frequency = <400000>; >> +status = "okay"; >> + >> +touchscreen@5d { >> +compatible = "goodix,gt9271"; >> +reg = <0x5d>; >> +interrupt-parent = <&pio>; >> +interrupts = <6 IRQ_TYPE_EDGE_RISING>; >> +irq-gpios = <&pio 6 GPIO_ACTIVE_HIGH>; >> +reset-gpios = <&pio 5 GPIO_ACTIVE_HIGH>; >> +AVDD28-supply = <&touch0_fixed_3v3>; >> +VDDIO-supply = <&mt6359_vio18_ldo_reg>; >> +pinctrl-names = "default"; >> +pinctrl-0 = <&touch_pins>; >> +}; >> +}; >> + >> +&i2c1 { >> +pinctrl-names = "default"; >> +pinctrl-0 = <&i2c1_pins>; >> +clock-frequency = <400000>; >> +status = "okay"; >> +}; >> + >> +&i2c2 { >> +pinctrl-names = "default"; >> +pinctrl-0 = <&i2c2_pins>; >> +clock-frequency = <400000>; >> +status = "okay"; >> +}; >> + >> +&i2c3 { >> +pinctrl-names = "default"; >> +pinctrl-0 = <&i2c3_pins>; >> +clock-frequency = <400000>; >> +status = "okay"; >> +}; >> + >> +&i2c4 { >> +pinctrl-names = "default", "default"; > > Why do you need two default entries? This should be just one, shouldn't it? Fixed. > Best regards, > Krzysztof > Thanks for the review. Best regards, Macpaul Lin
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index d8e449c6a7d7..047204a4aff5 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -251,6 +251,12 @@ properties: - items: - const: mediatek,mt8365-evk - const: mediatek,mt8365 + - description: MediaTek Genio 700 Boards (Genio 700 EVK) + items: + - enum: + - mediatek,mt8390-evk + - const: mediatek,mt8390 + - const: mediatek,mt8188 - description: MediaTek Genio 1200 Boards (Genio 1200 EVK) items: - enum:
1. Add compatible for MT8390. 2. Add bindings for the MediaTek mt8390-evk board, also known as the "Genio 700-EVK". The MT8390 and MT8188 belong to the same SoC family, with only minor differences in their physical characteristics. They utilize unique efuse values for differentiation. The booting process and configurations are managed by boot loaders, firmware, and TF-A. Consequently, the part numbers and procurement channels vary. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++ 1 file changed, 6 insertions(+) dependencies for v1: - This patch should be applied after the following patch set - mt8365's bindings - https://lore.kernel.org/linux-arm-kernel/20230912092444.31635-1-macpaul.lin@mediatek.com/T/ - mt8395's bindings - https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/ - mt8188's bindings - https://lore.kernel.org/lkml/a4e1a80ebd19896410f50b0297e05dce06fb47cc.camel@mediatek.com/T/