| Message ID | 20230912092444.31635-1-macpaul.lin@mediatek.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v4,1/2] dt-bindings: arm64: dts: mediatek: mt8365-evk: update compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 12/09/2023 11:24, Macpaul Lin wrote: > Update compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'. This we see from the diff. But why? Sorry, this change is pointless. Also not really helpful, as the entry soon should be converted back to enum... > Best regards, Krzysztof
On 9/12/23 22:34, Krzysztof Kozlowski wrote: > > > External email : Please do not click links or open attachments until you > have verified the sender or the content. > > On 12/09/2023 11:24, Macpaul Lin wrote: >> Update compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'. > > This we see from the diff. But why? Sorry, this change is pointless. > Also not really helpful, as the entry soon should be converted back to > enum... >> Okay, then this patch can be dropped now. Will send v5 patch for renaming mt8365-evk.dts. > Best regards, > Krzysztof > Thanks Macpaul Lin
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 2e8ad49c3479..9031160ef41b 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -245,8 +245,7 @@ properties: - mediatek,mt8183-pumpkin - const: mediatek,mt8183 - items: - - enum: - - mediatek,mt8365-evk + - const: mediatek,mt8365-evk - const: mediatek,mt8365 - description: MediaTek Genio 1200 Boards (Genio 1200 EVK) items:
Update compatible of 'mediatek,mt8365-evk' from 'enum' to 'const'. Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> --- Documentation/devicetree/bindings/arm/mediatek.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) changes for v2: - rebase this patch to follow the v5 patch set of mt8395. - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/ - Fix description as a single board. changes for v3: - rebase this patch to follow the v6 patch set of mt8395. - depends on https://lore.kernel.org/lkml/20230911115717.26184-1-macpaul.lin@mediatek.com/T/ - drop "Fixes:" tag in commit message. - drop platform description update for mt8365-evk (Genio 350-EVK). changes for v4: - Replace "Fix" in commit message with "Update". - Fix 'make dtbs_check W=1' error for 'const: mediatek,mt8365-evk'