diff mbox series

[v2,2/2] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range maxItems

Message ID 20230910125726.1243652-2-festevam@gmail.com
State Changes Requested
Headers show
Series None | expand

Checks

Context Check Description
robh/checkpatch warning total: 0 errors, 1 warnings, 9 lines checked
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 10, 2023, 12:57 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

imx93 has a maximum of seven entries for fsl,tmu-range.

Change it accordingly.

This fixes the following schema warning:

imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed:
	[2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Reduce the context of the schema warning in the commit log.

 Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 11, 2023, 6:14 a.m. UTC | #1 
On 10/09/2023 14:57, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> imx93 has a maximum of seven entries for fsl,tmu-range.
> 

Then qoriq should have it constrained to 4 entries.

Best regards,
Krzysztof
Fabio Estevam Sept. 11, 2023, 9:03 p.m. UTC | #2 
Hi Krzysztof,

On Mon, Sep 11, 2023 at 3:14 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/09/2023 14:57, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > imx93 has a maximum of seven entries for fsl,tmu-range.
> >
>
> Then qoriq should have it constrained to 4 entries.

I just noticed that fsl-lx2160a.dtsi is also has a tmu compatible with
two entries.

Would it be OK to represent it like this?

--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
@@ -33,7 +33,8 @@ properties:
     description: |
       The values to be programmed into TTRnCR, as specified by the SoC
       reference manual. The first cell is TTR0CR, the second is TTR1CR, etc.
-    maxItems: 4
+    minItems: 2
+    maxItems: 7
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
index 145744027234..d3734fc66f78 100644
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
@@ -33,7 +33,8 @@  properties:
     description: |
       The values to be programmed into TTRnCR, as specified by the SoC
       reference manual. The first cell is TTR0CR, the second is TTR1CR, etc.
-    maxItems: 4
+    minItems: 4
+    maxItems: 7
 
   fsl,tmu-calibration:
     $ref: /schemas/types.yaml#/definitions/uint32-matrix