diff mbox series

[1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

Message ID 20230909202957.1120153-1-festevam@gmail.com
State Not Applicable
Headers show
Series [1/3] dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Fabio Estevam Sept. 9, 2023, 8:29 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware
used for connecting, disconnecting and switching orientation of
the SBU lines in USB Type-C applications.

CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Sept. 10, 2023, 9:32 a.m. UTC | #1
On Sat, Sep 09, 2023 at 05:29:55PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware
> used for connecting, disconnecting and switching orientation of
> the SBU lines in USB Type-C applications.
> 
> CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> index f196beb826d8..b61dcf8b4aad 100644
> --- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> +++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
> @@ -19,6 +19,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - nxp,cbdtu02043
>            - onnn,fsusb43l10x
>            - pericom,pi3usb102
>        - const: gpio-sbu-mux

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Krzysztof Kozlowski Sept. 10, 2023, 10:52 a.m. UTC | #2
On 09/09/2023 22:29, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per gpio-sbu-mux.yaml, the compatible entry is incomplete.
> 
> The imx8qxp-mek board uses a CBDTU02043, so complete the gpio-sbu-mux
> compatible accordingly.
> 
> This fixes the following schema warning:
> 
> imx8qxp-mek.dtb: gpio-sbu-mux: compatible:0: 'gpio-sbu-mux' is not one of ['onnn,fsusb43l10x', 'pericom,pi3usb102']
> 	from schema $id: http://devicetree.org/schemas/usb/gpio-sbu-mux.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 7924b0969ad8..a06a6491ef20 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -31,7 +31,7 @@ reg_usdhc2_vmmc: usdhc2-vmmc {
>  	};
>  
>  	gpio-sbu-mux {
> -		compatible = "gpio-sbu-mux";
> +		compatible = "nxp,cbdtu02043","gpio-sbu-mux";

Missing space after ,

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
index f196beb826d8..b61dcf8b4aad 100644
--- a/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
+++ b/Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml
@@ -19,6 +19,7 @@  properties:
   compatible:
     items:
       - enum:
+          - nxp,cbdtu02043
           - onnn,fsusb43l10x
           - pericom,pi3usb102
       - const: gpio-sbu-mux