| Message ID | 20230909123107.1048998-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: net: fec: Add imx8dxl description | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, Sep 09, 2023 at 09:31:06AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The imx8dl FEC has the same programming model as the one on the imx8qxp. > > Add the imx8dl compatible string. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/net/fsl,fec.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml > index b494e009326e..8948a11c994e 100644 > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml > @@ -59,6 +59,7 @@ properties: > - const: fsl,imx6sx-fec > - items: > - enum: > + - fsl,imx8dxl-fec > - fsl,imx8qxp-fec > - const: fsl,imx8qm-fec > - const: fsl,imx6sx-fec > -- > 2.34.1 >
Hi, On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > This fixes the following schema warning: > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx8qm-fec'] is too short > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > 'fsl,imx8mq-fec' was expected > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> It looks like this series is targeting the net-next tree, am I misreading this? I guess we could have small conflicts whatever target tree we will use, so I *think* the above should be ok. @Shawn Guo: do you prefer otherwise? Thanks, Paolo
On Tue, 2023-09-12 at 10:09 +0200, Paolo Abeni wrote: > Hi, > > On Sat, 2023-09-09 at 09:31 -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > > > This fixes the following schema warning: > > > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx8qm-fec'] is too short > > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > > 'fsl,imx8mq-fec' was expected > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > It looks like this series is targeting the net-next tree, am I > misreading this? > > I guess we could have small conflicts whatever target tree we will use, > so I *think* the above should be ok. @Shawn Guo: do you prefer > otherwise? Thinking again about it, I assume this should go via the devicetree git tree, so I'm dropping it from the netdev pw. Please correct me otherwise, thanks! Paolo
Hi Paolo, On 14/09/2023 03:16, Paolo Abeni wrote: > Thinking again about it, I assume this should go via the devicetree git > tree, so I'm dropping it from the netdev pw. You're right. This one should go via Shawn's tree. Thanks
On Sat, Sep 09, 2023 at 09:31:07AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Use the full compatible list for the imx8dl FEC as per fsl,fec.yaml. > > This fixes the following schema warning: > > imx8dxl-evk.dtb: ethernet@5b040000: compatible: 'oneOf' conditional failed, one must be fixed: > ['fsl,imx8qm-fec'] is too short > 'fsl,imx8qm-fec' is not one of ['fsl,imx25-fec', 'fsl,imx27-fec', 'fsl,imx28-fec', 'fsl,imx6q-fec', 'fsl,mvf600-fec', 'fsl,s32v234-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx53-fec', 'fsl,imx6sl-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx35-fec', 'fsl,imx51-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx6ul-fec', 'fsl,imx6sx-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx7d-fec'] > 'fsl,imx8mq-fec' was expected > 'fsl,imx8qm-fec' is not one of ['fsl,imx8mm-fec', 'fsl,imx8mn-fec', 'fsl,imx8mp-fec', 'fsl,imx93-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8dxl-fec', 'fsl,imx8qxp-fec'] > 'fsl,imx8qm-fec' is not one of ['fsl,imx8ulp-fec'] > from schema $id: http://devicetree.org/schemas/net/fsl,fec.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml b/Documentation/devicetree/bindings/net/fsl,fec.yaml index b494e009326e..8948a11c994e 100644 --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml @@ -59,6 +59,7 @@ properties: - const: fsl,imx6sx-fec - items: - enum: + - fsl,imx8dxl-fec - fsl,imx8qxp-fec - const: fsl,imx8qm-fec - const: fsl,imx6sx-fec