| Message ID | 20230906095542.3280699-4-sarah.walker@imgtec.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Imagination Technologies PowerVR DRM driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, 6 Sep 2023 10:55:25 +0100, Sarah Walker wrote: > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns <frank.binns@imgtec.com> > Signed-off-by: Frank Binns <frank.binns@imgtec.com> > > [ ... ] Reviewed-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On Wed, 6 Sep 2023 10:55:25 +0100, Sarah Walker wrote: > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns <frank.binns@imgtec.com> > Signed-off-by: Frank Binns <frank.binns@imgtec.com> > > [ ... ] Reviewed-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
On Wed, Sep 6, 2023 at 11:56 AM Sarah Walker <sarah.walker@imgtec.com> wrote: > Add the device tree binding documentation for the IMG AXE GPU used in > TI AM62 SoCs. > > Co-developed-by: Frank Binns <frank.binns@imgtec.com> > Signed-off-by: Frank Binns <frank.binns@imgtec.com> > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com> > --- > Changes since v5: > - Update compatible string & description to match marketing name > - Remove unnecessary clock-names definition in ti,am62-gpu constraints > - Document that GPU revision is discoverable This looks good to me! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hey, On Wed, Sep 06, 2023 at 10:55:25AM +0100, Sarah Walker wrote: > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + > + gpu: gpu@fd00000 { This "gpu" label isn't used and can be dropped if you respin. Otherwise, this seems fine to me, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > + compatible = "ti,am62-gpu", "img,img-axe"; > + reg = <0x0fd00000 0x20000>; > + clocks = <&k3_clks 187 0>; > + clock-names = "core"; > + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; > + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>; > + };
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentation/devicetree/bindings/gpu/img,powervr.yaml new file mode 100644 index 000000000000..51ee0f3d6e48 --- /dev/null +++ b/Documentation/devicetree/bindings/gpu/img,powervr.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2023 Imagination Technologies Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpu/img,powervr.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Imagination Technologies PowerVR and IMG GPU + +maintainers: + - Sarah Walker <sarah.walker@imgtec.com> + +properties: + compatible: + items: + - enum: + - ti,am62-gpu + - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable + + reg: + maxItems: 1 + + clocks: + minItems: 1 + maxItems: 3 + + clock-names: + items: + - const: core + - const: mem + - const: sys + minItems: 1 + + interrupts: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + +additionalProperties: false + +allOf: + - if: + properties: + compatible: + contains: + const: ti,am62-gpu + then: + properties: + clocks: + maxItems: 1 + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/soc/ti,sci_pm_domain.h> + + gpu: gpu@fd00000 { + compatible = "ti,am62-gpu", "img,img-axe"; + reg = <0x0fd00000 0x20000>; + clocks = <&k3_clks 187 0>; + clock-names = "core"; + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 231a5e6fd52e..c057daebbfc1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10140,6 +10140,13 @@ IMGTEC IR DECODER DRIVER S: Orphan F: drivers/media/rc/img-ir/ +IMGTEC POWERVR DRM DRIVER +M: Frank Binns <frank.binns@imgtec.com> +M: Sarah Walker <sarah.walker@imgtec.com> +M: Donald Robson <donald.robson@imgtec.com> +S: Supported +F: Documentation/devicetree/bindings/gpu/img,powervr.yaml + IMON SOUNDGRAPH USB IR RECEIVER M: Sean Young <sean@mess.org> L: linux-media@vger.kernel.org