| Message ID | 20230905220826.79901-1-festevam@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3] dt-bindings: rtc: pcf8523: Convert to YAML | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 2 warnings, 45 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 06/09/2023 00:08, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Convert the PCF8523 bindings from text format to YAML. > > The YAML format is preferred as it allows validation. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v2: > - Fix the default quartz-load-femtofarads value. (Javier) > For the future, please keep also previous changelogs. Otherwise I would assume that my feedback from v1 was not implemented. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Fabio, On Tue, Sep 05, 2023 at 07:08:26PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Convert the PCF8523 bindings from text format to YAML. > > The YAML format is preferred as it allows validation. > > Signed-off-by: Fabio Estevam <festevam@denx.de> Looks good, Reviewed-by: Sam Ravnborg <sam@ravnborg.org> I assume the dt people (or rtc people) will land this. Sam
On Tue, 05 Sep 2023 19:08:26 -0300, Fabio Estevam wrote: > Convert the PCF8523 bindings from text format to YAML. > > The YAML format is preferred as it allows validation. > > Applied, thanks! [1/1] dt-bindings: rtc: pcf8523: Convert to YAML commit: 539cbe1b81f44e13103795e41f2e000fdc170859 Best regards,
diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt deleted file mode 100644 index 0b1080c60f63..000000000000 --- a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.txt +++ /dev/null @@ -1,18 +0,0 @@ -* NXP PCF8523 Real Time Clock - -Required properties: -- compatible: Should contain "nxp,pcf8523". -- reg: I2C address for chip. - -Optional property: -- quartz-load-femtofarads: The capacitive load of the quartz(x-tal), - expressed in femto Farad (fF). Valid values are 7000 and 12500. - Default value (if no value is specified) is 12500fF. - -Example: - -pcf8523: rtc@68 { - compatible = "nxp,pcf8523"; - reg = <0x68>; - quartz-load-femtofarads = <7000>; -}; diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml new file mode 100644 index 000000000000..8d17b89fef5e --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8523.yaml @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/nxp,pcf8523.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP PCF8523 Real Time Clock + +maintainers: + - Sam Ravnborg <sam@ravnborg.org> + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + const: nxp,pcf8523 + + reg: + maxItems: 1 + + quartz-load-femtofarads: + description: + The capacitive load of the crystal, expressed in femto Farad (fF). + enum: [ 7000, 12500 ] + default: 12500 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@68 { + compatible = "nxp,pcf8523"; + reg = <0x68>; + quartz-load-femtofarads = <7000>; + }; + };