| Message ID | 20230830-fp5-initial-v1-10-5a954519bbad@fairphone.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Initial support for the Fairphone 5 smartphone | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 30/08/2023 11:58, Luca Weiss wrote: > Fairphone 5 is a smartphone based on the QCM6490 SoC. > > Also allow qcom,board-id and qcom,msm-id for QCM6490 since it's required > by the bootloader. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index adbfaea32343..b09a41812cf0 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -391,6 +391,11 @@ properties: > - const: qcom,qrb2210 > - const: qcom,qcm2290 > > + - items: > + - enum: > + - fairphone,fp5 > + - const: qcom,qcm6490 You miss update to first list of SoCs for bootloader. > + > - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform > items: > - enum: > @@ -1074,6 +1079,7 @@ allOf: > - qcom,msm8994 > - qcom,msm8996 > - qcom,msm8998 > + - qcom,qcm6490 This is not a legacy SoC (released in 2022). Not allowed. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index adbfaea32343..b09a41812cf0 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -391,6 +391,11 @@ properties: - const: qcom,qrb2210 - const: qcom,qcm2290 + - items: + - enum: + - fairphone,fp5 + - const: qcom,qcm6490 + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform items: - enum: @@ -1074,6 +1079,7 @@ allOf: - qcom,msm8994 - qcom,msm8996 - qcom,msm8998 + - qcom,qcm6490 - qcom,sdm450 - qcom,sdm630 - qcom,sdm632
Fairphone 5 is a smartphone based on the QCM6490 SoC. Also allow qcom,board-id and qcom,msm-id for QCM6490 since it's required by the bootloader. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ 1 file changed, 6 insertions(+)