| Message ID | 20230829135818.2219438-6-quic_ipkumar@quicinc.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Enable USB3 for IPQ5332 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On 29/08/2023 15:58, Praveenkumar I wrote: > IPQ5332 USB supports both USB2 and USB3. Updated the USB clocks > for the same. Subject: everything is an update. You are not updating compatible, but adding clocks. Describe your changes properly. > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> I think I repeat this third time to Qualcomm this week. Split unrelated patches touching other subsystems to separate patchsets. Please share it with your colleagues, so there won't be a need to repeat it fourth time. > --- > .../devicetree/bindings/usb/qcom,dwc3.yaml | 20 ++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > ' Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml index 67591057f234..18af2887b984 100644 --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml @@ -149,6 +149,25 @@ allOf: - const: sleep - const: mock_utmi + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq5332-dwc3 + then: + properties: + clocks: + maxItems: 6 + clock-names: + items: + - const: core + - const: iface + - const: sleep + - const: mock_utmi + - const: aux + - const: lfps + - if: properties: compatible: @@ -238,7 +257,6 @@ allOf: compatible: contains: enum: - - qcom,ipq5332-dwc3 - qcom,msm8994-dwc3 - qcom,qcs404-dwc3 then:
IPQ5332 USB supports both USB2 and USB3. Updated the USB clocks for the same. Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> --- .../devicetree/bindings/usb/qcom,dwc3.yaml | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)