diff mbox series

[1/3] dt-bindings: clock: qcom,a53pll: add IPQ5018 compatible

Message ID 20230829095423.760641-2-quic_gokulsri@quicinc.com
State Not Applicable
Headers show
Series Add APSS clock driver support for IPQ5018 | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Gokul Sriram P Aug. 29, 2023, 9:54 a.m. UTC 
Add IPQ5018 compatible to A53 PLL bindings.

Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,a53pll.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Aug. 29, 2023, 10:09 a.m. UTC | #1 
On 29/08/2023 11:54, Gokul Sriram Palanisamy wrote:
> Add IPQ5018 compatible to A53 PLL bindings.
> 
> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>

Knowing that this patch could not come from downstream (it's some old
kernel without this file), I really wonder why two people were involved
in developing trivial one line change.

> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Gokul Sriram P Aug. 30, 2023, 6:40 a.m. UTC | #2 
On 8/29/2023 3:39 PM, Krzysztof Kozlowski wrote:
> On 29/08/2023 11:54, Gokul Sriram Palanisamy wrote:
>> Add IPQ5018 compatible to A53 PLL bindings.
>>
>> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> Knowing that this patch could not come from downstream (it's some old
> kernel without this file), I really wonder why two people were involved
> in developing trivial one line change.
Sure, I had kept this co-developed-by for this whole series of patches. 
will remove co-developed-by for this patch.

Regards,
Gokul
Dmitry Baryshkov Aug. 30, 2023, 7:47 p.m. UTC | #3 
On Wed, 30 Aug 2023 at 21:31, Gokul Sriram P <quic_gokulsri@quicinc.com> wrote:
>
>
> On 8/29/2023 3:39 PM, Krzysztof Kozlowski wrote:
> > On 29/08/2023 11:54, Gokul Sriram Palanisamy wrote:
> >> Add IPQ5018 compatible to A53 PLL bindings.
> >>
> >> Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > Knowing that this patch could not come from downstream (it's some old
> > kernel without this file), I really wonder why two people were involved
> > in developing trivial one line change.
> Sure, I had kept this co-developed-by for this whole series of patches.
> will remove co-developed-by for this patch.

Each patch is individual, even if they form a series. Different
patches might be developed by different parties or a combination of
them.
Gokul Sriram P Aug. 31, 2023, 3:26 a.m. UTC | #4 
On 8/31/2023 1:17 AM, Dmitry Baryshkov wrote:
> Each patch is individual, even if they form a series. Different
> patches might be developed by different parties or a combination of
> them.

I get it Dmitry. Thanks. Will update.

Regards,
Gokul
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
index 9436266828af..5ca927a8b1d5 100644
--- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
@@ -16,6 +16,7 @@  description:
 properties:
   compatible:
     enum:
+      - qcom,ipq5018-a53pll
       - qcom,ipq5332-a53pll
       - qcom,ipq6018-a53pll
       - qcom,ipq8074-a53pll