diff mbox series

dt-bindings: mips: loongson: Add LS1B demo board

Message ID 20230825124115.1177577-1-keguang.zhang@gmail.com
State Changes Requested, archived
Headers show
Series dt-bindings: mips: loongson: Add LS1B demo board | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Keguang Zhang Aug. 25, 2023, 12:41 p.m. UTC 
Add compatible for LS1B demo board.

Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
 Documentation/devicetree/bindings/mips/loongson/devices.yaml | 1 +
 1 file changed, 1 insertion(+)


base-commit: f11a9967413281b49690d864795e7c5f8f8e4fda

Comments

Krzysztof Kozlowski Aug. 25, 2023, 12:45 p.m. UTC | #1 
On 25/08/2023 14:41, Keguang Zhang wrote:
> Add compatible for LS1B demo board.

Where is the user of this binding? We do not add bindings without users.


Best regards,
Krzysztof
Keguang Zhang Aug. 25, 2023, 2:39 p.m. UTC | #2 
On Fri, Aug 25, 2023 at 8:45 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/08/2023 14:41, Keguang Zhang wrote:
> > Add compatible for LS1B demo board.
>
> Where is the user of this binding? We do not add bindings without users.
>
OK. I'll put this patch and the DTS into one patch set later.
>
> Best regards,
> Krzysztof
>
Rob Herring (Arm) Aug. 28, 2023, 3:09 p.m. UTC | #3 
On Fri, Aug 25, 2023 at 02:45:41PM +0200, Krzysztof Kozlowski wrote:
> On 25/08/2023 14:41, Keguang Zhang wrote:
> > Add compatible for LS1B demo board.
> 
> Where is the user of this binding? We do not add bindings without users.

Maybe board compatibles should be an exception? They are rarely/never 
used by the kernel so the only user will be a board dts. I'm not sure we 
care about having every board upstream.

Rob
Krzysztof Kozlowski Aug. 28, 2023, 5:01 p.m. UTC | #4 
On 28/08/2023 17:09, Rob Herring wrote:
> On Fri, Aug 25, 2023 at 02:45:41PM +0200, Krzysztof Kozlowski wrote:
>> On 25/08/2023 14:41, Keguang Zhang wrote:
>>> Add compatible for LS1B demo board.
>>
>> Where is the user of this binding? We do not add bindings without users.
> 
> Maybe board compatibles should be an exception? They are rarely/never 
> used by the kernel so the only user will be a board dts. I'm not sure we 
> care about having every board upstream.

If someone keeps DTS out of the kernel, then they could keep the binding
patch there as well.

Boards upstream are the same useful as some drivers - allow others to
play with it and investigate.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index 099e40e1482d..8736eb9fe224 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -40,6 +40,7 @@  properties:
       - description: LS1B based boards
         items:
           - enum:
+              - loongson,ls1b-demo
               - loongson,lsgz-1b-dev
           - const: loongson,ls1b