| Message ID | 20230824111015.57765-4-m.zatovic1@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Wiegand bus driver and GPIO bitbanged controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 24 Aug 2023 13:10:14 +0200, Martin Zaťovič wrote: > GPIO bitbanged Wiegand controller requires definitions of GPIO lines to be > used on top of the common Wiegand properties. Wiegand utilizes two such > lines - DATA0(low data line) and DATA1(high data line). > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Martin Zaťovič <m.zatovic1@gmail.com> > --- > .../bindings/wiegand/wiegand-gpio.yaml | 46 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/wiegand/wiegand-gpio.example.dts:20.21-29.11: Warning (unit_address_vs_reg): /example-0/wiegand@f00: node has a unit name, but no reg or ranges property doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230824111015.57765-4-m.zatovic1@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Aug 24, 2023 at 01:10:14PM +0200, Martin Zaťovič wrote: > GPIO bitbanged Wiegand controller requires definitions of GPIO lines to be > used on top of the common Wiegand properties. Wiegand utilizes two such > lines - DATA0(low data line) and DATA1(high data line). > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Martin Zaťovič <m.zatovic1@gmail.com> > --- > .../bindings/wiegand/wiegand-gpio.yaml | 46 +++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > > diff --git a/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > new file mode 100644 > index 000000000000..cf2cb938de02 > --- /dev/null > +++ b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/wiegand/wiegand-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: GPIO bitbanged Wiegand interface properties > + > +maintainers: > + - Martin Zaťovič <m.zatovic1@gmail.com> > + > +description: > + This represents the GPIO lines used for bit-banged Wiegand on dedicated GPIO > + lines. > + > +allOf: > + - $ref: /schemas/wiegand/wiegand-controller.yaml# > + > +properties: > + compatible: > + const: wiegand-gpio > + > + data-gpios: > + description: GPIOs used as Wiegand data lines, DATA0 and DATA1 respectivelly. > + maxItems: 2 > + > +required: > + - compatible > + - data-gpios > + > +unevaluatedProperties: false You'll find this fails if you add an actual child node. Assuming you go with only 1 child node allowed, then you need: unevaluatedProperties: type: object (There's not any way to say only 1 child, but multiple would have constraints in the common binding as I explained.) Rob
diff --git a/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml new file mode 100644 index 000000000000..cf2cb938de02 --- /dev/null +++ b/Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/wiegand/wiegand-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GPIO bitbanged Wiegand interface properties + +maintainers: + - Martin Zaťovič <m.zatovic1@gmail.com> + +description: + This represents the GPIO lines used for bit-banged Wiegand on dedicated GPIO + lines. + +allOf: + - $ref: /schemas/wiegand/wiegand-controller.yaml# + +properties: + compatible: + const: wiegand-gpio + + data-gpios: + description: GPIOs used as Wiegand data lines, DATA0 and DATA1 respectivelly. + maxItems: 2 + +required: + - compatible + - data-gpios + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + wiegand@f00 { + compatible = "wiegand-gpio"; + pulse-len-us = <50>; + interval-len-us = <2000>; + frame-gap-us = <2000>; + data-gpios = <&gpio2 6 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>, + <&gpio2 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; + + /* devices */ + }; diff --git a/MAINTAINERS b/MAINTAINERS index 0afcc88a38d2..fb158e74ca4b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22929,6 +22929,11 @@ F: Documentation/devicetree/bindings/wiegand/wiegand-controller.yaml F: drivers/wiegand/wiegand.c F: include/linux/wiegand.h +WIEGAND GPIO BITBANG DRIVER +M: Martin Zaťovič <m.zatovic1@gmail.com> +S: Maintained +F: Documentation/devicetree/bindings/wiegand/wiegand-gpio.yaml + WILOCITY WIL6210 WIRELESS DRIVER L: linux-wireless@vger.kernel.org S: Orphan