| Message ID | 20230817114527.1585631-3-danishanwar@ti.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Introduce IEP driver and packet timestamping support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | fail | build log |
On Thu, 2023-08-17 at 17:15 +0530, MD Danish Anwar wrote: > Add IEP node in ICSSG driver DT binding document. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: MD Danish Anwar <danishanwar@ti.com> > --- > Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > index 8ec30b3eb760..a736d1424ea4 100644 > --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml > @@ -52,6 +52,12 @@ properties: > description: > phandle to MII_RT module's syscon regmap > > + ti,iep: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + maxItems: 2 > + description: > + phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver It looks like the feedback given by Rob on v2: https://lore.kernel.org/all/20230821160120.GA1734560-robh@kernel.org/ still applies here, I guess you need to address it. Cheers, Paolo -- pw-bot: cr
On 22/08/23 2:36 pm, Paolo Abeni wrote: > On Thu, 2023-08-17 at 17:15 +0530, MD Danish Anwar wrote: >> Add IEP node in ICSSG driver DT binding document. >> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com> >> --- >> Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml >> index 8ec30b3eb760..a736d1424ea4 100644 >> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml >> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml >> @@ -52,6 +52,12 @@ properties: >> description: >> phandle to MII_RT module's syscon regmap >> >> + ti,iep: >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + maxItems: 2 >> + description: >> + phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver > > It looks like the feedback given by Rob on v2: > > https://lore.kernel.org/all/20230821160120.GA1734560-robh@kernel.org/ > > still applies here, I guess you need to address it. Sure, Paolo. I will address the feedback and post v6 soon. > > Cheers, > > Paolo > > -- > pw-bot: cr >
diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml index 8ec30b3eb760..a736d1424ea4 100644 --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml @@ -52,6 +52,12 @@ properties: description: phandle to MII_RT module's syscon regmap + ti,iep: + $ref: /schemas/types.yaml#/definitions/phandle-array + maxItems: 2 + description: + phandle to IEP (Industrial Ethernet Peripheral) for ICSSG driver + interrupts: maxItems: 2 description: @@ -155,6 +161,7 @@ examples: "tx1-0", "tx1-1", "tx1-2", "tx1-3", "rx0", "rx1"; ti,mii-g-rt = <&icssg2_mii_g_rt>; + ti,iep = <&icssg2_iep0>, <&icssg2_iep1>; interrupt-parent = <&icssg2_intc>; interrupts = <24 0 2>, <25 1 3>; interrupt-names = "tx_ts0", "tx_ts1";