Message ID | 20230816080006.1624342-1-wtli@nuvoton.com |
---|---|
State | Not Applicable, archived |
Headers | show |
Series | [1/2] ASoC: dt-bindings: nau8821: Add single-ended input feature | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | fail | build log |
On Wed, Aug 16, 2023 at 04:00:06PM +0800, Seven Lee wrote: > Since the hardware may be designed as a single-ended input, the headset mic > record only supports single-ended input on the left side. This patch > will enhance microphone recording performance for single-end. The new property looks fine but you need to fix the build error 0day reported.
On Wed, 16 Aug 2023 16:00:05 +0800, Seven Lee wrote: > Add input with single-ended control. > > Signed-off-by: Seven Lee <wtli@nuvoton.com> > --- > .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, Aug 22, 2023 at 06:49:50PM +0800, AS50 WTLi wrote: > Okay, but I have a question. After correcting the patch, do I only upload patch 2/2 or resend the entire patch? > because I saw Acked mail by Rob. Please resend everything, include any acks or other tags you've already got when you repost.
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml index fc2f4ce4db88..3e54abd4ca74 100644 --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml @@ -89,6 +89,12 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 default: 3072000 + nuvoton,left-input-single-end: + description: Enable left input with single-ended settings if set. + For the headset mic application, the single-ended control is + just limited to the left adc for design demand. + type: boolean + '#sound-dai-cells': const: 0 @@ -114,6 +120,7 @@ examples: nuvoton,jkdet-pull-enable; nuvoton,jkdet-pull-up; nuvoton,key-enable; + nuvoton,left-input-single-end; nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>; nuvoton,micbias-voltage = <6>; nuvoton,vref-impedance = <2>;
Add input with single-ended control. Signed-off-by: Seven Lee <wtli@nuvoton.com> --- .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 7 +++++++ 1 file changed, 7 insertions(+)