| Message ID | 20230810174356.3322583-3-vigneshr@ti.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: dma: ti: k3* : Update optional reg regions | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 10/08/2023 20:43, Vignesh Raghavendra wrote: > Packet DMA (PKTDMA) module on K3 SoCs have ring cfg, TX and RX channel > cfg and RX flow cfg register regions which are usually configured by a > Device Management firmware. But certain entities such as bootloader > (like U-Boot) may have to access them directly. Describe this region in > the binding documentation for completeness of module description. > > Keep the binding compatible with existing DTS files by requiring first > four regions to be present at least. > > Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> > --- > .../devicetree/bindings/dma/ti/k3-pktdma.yaml | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml > index a69f62f854d8..5f9ba4bb05f6 100644 > --- a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml > +++ b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml > @@ -45,14 +45,20 @@ properties: > The second cell is the ASEL value for the channel > > reg: > - maxItems: 4 > + minItems: 4 > + maxItems: 8 > > reg-names: > + minItems: 4 > items: > - const: gcfg > - const: rchanrt > - const: tchanrt > - const: ringrt > + - const: cfg > + - const: tchan > + - const: rchan > + - const: rflow > > msi-parent: true > > @@ -136,8 +142,14 @@ examples: > reg = <0x0 0x485c0000 0x0 0x100>, > <0x0 0x4a800000 0x0 0x20000>, > <0x0 0x4aa00000 0x0 0x40000>, > - <0x0 0x4b800000 0x0 0x400000>; > - reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt"; > + <0x0 0x4b800000 0x0 0x400000>, > + <0x00 0x485e0000 0x00 0x20000>, This is RING (PKTDMA_RING), why it is named cfg? > + <0x00 0x484a0000 0x00 0x4000>, > + <0x00 0x484c0000 0x00 0x2000>, > + <0x00 0x48430000 0x00 0x4000>; > + reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt", > + "cfg", "tchan", "rchan", "rflow"; > + > msi-parent = <&inta_main_dmss>; > #dma-cells = <2>; >
diff --git a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml index a69f62f854d8..5f9ba4bb05f6 100644 --- a/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml +++ b/Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml @@ -45,14 +45,20 @@ properties: The second cell is the ASEL value for the channel reg: - maxItems: 4 + minItems: 4 + maxItems: 8 reg-names: + minItems: 4 items: - const: gcfg - const: rchanrt - const: tchanrt - const: ringrt + - const: cfg + - const: tchan + - const: rchan + - const: rflow msi-parent: true @@ -136,8 +142,14 @@ examples: reg = <0x0 0x485c0000 0x0 0x100>, <0x0 0x4a800000 0x0 0x20000>, <0x0 0x4aa00000 0x0 0x40000>, - <0x0 0x4b800000 0x0 0x400000>; - reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt"; + <0x0 0x4b800000 0x0 0x400000>, + <0x00 0x485e0000 0x00 0x20000>, + <0x00 0x484a0000 0x00 0x4000>, + <0x00 0x484c0000 0x00 0x2000>, + <0x00 0x48430000 0x00 0x4000>; + reg-names = "gcfg", "rchanrt", "tchanrt", "ringrt", + "cfg", "tchan", "rchan", "rflow"; + msi-parent = <&inta_main_dmss>; #dma-cells = <2>;
Packet DMA (PKTDMA) module on K3 SoCs have ring cfg, TX and RX channel cfg and RX flow cfg register regions which are usually configured by a Device Management firmware. But certain entities such as bootloader (like U-Boot) may have to access them directly. Describe this region in the binding documentation for completeness of module description. Keep the binding compatible with existing DTS files by requiring first four regions to be present at least. Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> --- .../devicetree/bindings/dma/ti/k3-pktdma.yaml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-)