| Message ID | 20230810110545.11644-1-hnagalla@ti.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Thu, 10 Aug 2023 06:05:45 -0500, Hari Nagalla wrote: > The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It > does not have an addressable l1dram . So, remove this optional sram > property from the bindings to fix device tree build warnings. > > Also set the 'memory-regions' property as optional. This is because > the remote processors can function without carveout regions. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810110545.11644-1-hnagalla@ti.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Thu, Aug 10, 2023 at 06:05:45AM -0500, Hari Nagalla wrote: > The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It > does not have an addressable l1dram . So, remove this optional sram > property from the bindings to fix device tree build warnings. > > Also set the 'memory-regions' property as optional. This is because > the remote processors can function without carveout regions. I thought I already said this today, but must be hallucinating - this second part here seems like it in an unrelated change that should go in its own patch.. > > Signed-off-by: Hari Nagalla <hnagalla@ti.com> > --- > .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > index f16e90380df1..8dd22c57e22d 100644 > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml > @@ -111,7 +111,6 @@ else: > properties: > compatible: > enum: > - - ti,am62a-c7xv-dsp > - ti,j721e-c71-dsp > - ti,j721s2-c71-dsp > then: > @@ -124,6 +123,20 @@ else: > items: > - const: l2sram > - const: l1dram > + else: > + if: > + properties: > + compatible: > + enum: > + - ti,am62a-c7xv-dsp > + then: > + properties: > + reg: > + items: > + - description: Address and Size of the L2 SRAM internal memory region > + reg-names: > + items: > + - const: l2sram > > required: > - compatible > @@ -135,7 +148,6 @@ required: > - resets > - firmware-name > - mboxes > - - memory-region > > unevaluatedProperties: false > > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml index f16e90380df1..8dd22c57e22d 100644 --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml @@ -111,7 +111,6 @@ else: properties: compatible: enum: - - ti,am62a-c7xv-dsp - ti,j721e-c71-dsp - ti,j721s2-c71-dsp then: @@ -124,6 +123,20 @@ else: items: - const: l2sram - const: l1dram + else: + if: + properties: + compatible: + enum: + - ti,am62a-c7xv-dsp + then: + properties: + reg: + items: + - description: Address and Size of the L2 SRAM internal memory region + reg-names: + items: + - const: l2sram required: - compatible @@ -135,7 +148,6 @@ required: - resets - firmware-name - mboxes - - memory-region unevaluatedProperties: false
The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It does not have an addressable l1dram . So, remove this optional sram property from the bindings to fix device tree build warnings. Also set the 'memory-regions' property as optional. This is because the remote processors can function without carveout regions. Signed-off-by: Hari Nagalla <hnagalla@ti.com> --- .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)