diff mbox series

[1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510

Message ID 20230808100746.391365-2-jbrunet@baylibre.com
State Changes Requested, archived
Headers show
Series usb: misc: onboard_usb_hub: add gl3510 support | expand

Checks

Context Check Description
robh/checkpatch success
robh/patch-applied success
robh/dtbs-check warning build log
robh/dt-meta-schema success

Commit Message

Jerome Brunet Aug. 8, 2023, 10:07 a.m. UTC
Add gl3510 USB 3 root hub device id

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) Aug. 10, 2023, 11:17 p.m. UTC | #1
On Tue, Aug 08, 2023 at 12:07:45PM +0200, Jerome Brunet wrote:
> Add gl3510 USB 3 root hub device id
> 
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index cc4cf92b70d1..a7e7142651f8 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Genesys Logic GL850G USB 2.0 hub controller
> +title: Genesys Logic USB hub controller
>  
>  maintainers:
>    - Icenowy Zheng <uwu@icenowy.me>
> @@ -17,6 +17,7 @@ properties:
>      enum:
>        - usb5e3,608
>        - usb5e3,610
> +      - usb5e3.626

Should be a comma, not a period.

>  
>    reg: true
>  
> -- 
> 2.40.1
>
Jerome Brunet Sept. 11, 2023, 4:46 p.m. UTC | #2
On Thu 10 Aug 2023 at 17:17, Rob Herring <robh@kernel.org> wrote:

> On Tue, Aug 08, 2023 at 12:07:45PM +0200, Jerome Brunet wrote:
>> Add gl3510 USB 3 root hub device id
>> 
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> ---
>>  Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> index cc4cf92b70d1..a7e7142651f8 100644
>> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> @@ -4,7 +4,7 @@
>>  $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>  
>> -title: Genesys Logic GL850G USB 2.0 hub controller
>> +title: Genesys Logic USB hub controller
>>  
>>  maintainers:
>>    - Icenowy Zheng <uwu@icenowy.me>
>> @@ -17,6 +17,7 @@ properties:
>>      enum:
>>        - usb5e3,608
>>        - usb5e3,610
>> +      - usb5e3.626
>
> Should be a comma, not a period.
>

Good catch, thanks a lot

>>  
>>    reg: true
>>  
>> -- 
>> 2.40.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
index cc4cf92b70d1..a7e7142651f8 100644
--- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
+++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Genesys Logic GL850G USB 2.0 hub controller
+title: Genesys Logic USB hub controller
 
 maintainers:
   - Icenowy Zheng <uwu@icenowy.me>
@@ -17,6 +17,7 @@  properties:
     enum:
       - usb5e3,608
       - usb5e3,610
+      - usb5e3.626
 
   reg: true