| Message ID | 20230805180506.718364-3-bigunclemax@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ASoC: sunxi: Add support for D1/T113s internal audio codec | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Sat, Aug 05, 2023 at 09:05:02PM +0300, Maksim Kiselev wrote: > Add a DT schema to describe the analog part of the Allwinner D1/T113s > internal audio codec. > > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> > --- > .../allwinner,sun20i-d1-codec-analog.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml Looks the same as allwinner,sun8i-a23-codec-analog.yaml. Why can't you use that? Rob
пн, 21 авг. 2023 г. в 19:47, Rob Herring <robh@kernel.org>: > > On Sat, Aug 05, 2023 at 09:05:02PM +0300, Maksim Kiselev wrote: > > Add a DT schema to describe the analog part of the Allwinner D1/T113s > > internal audio codec. > > > > Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> > > --- > > .../allwinner,sun20i-d1-codec-analog.yaml | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml > > Looks the same as allwinner,sun8i-a23-codec-analog.yaml. Why can't you > use that? > Hmm. You're right. But let me explain my decision :) When I added a new file, I assumed that since this is a separate driver, then the binding should be in a separate file. As an example, I looked at the sun50i-a64-codec-analog.yaml binding. It is mostly the same as sun8i-a23-codec-analog.yaml too. So I really don't know which approach is better. If you advise me just add a new compatible sting to sun8i-a23-codec-analog.yaml, then I'll gladly do it in the next version. Cheers, Maksim
On 23/08/2023 18:13, Maxim Kiselev wrote: > пн, 21 авг. 2023 г. в 19:47, Rob Herring <robh@kernel.org>: >> >> On Sat, Aug 05, 2023 at 09:05:02PM +0300, Maksim Kiselev wrote: >>> Add a DT schema to describe the analog part of the Allwinner D1/T113s >>> internal audio codec. >>> >>> Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> >>> --- >>> .../allwinner,sun20i-d1-codec-analog.yaml | 33 +++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml >> >> Looks the same as allwinner,sun8i-a23-codec-analog.yaml. Why can't you >> use that? >> > Hmm. You're right. But let me explain my decision :) > When I added a new file, I assumed that since this is a separate driver, > then the binding should be in a separate file. Driver architecture of one give OS does not matter for the bindings. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml new file mode 100644 index 000000000000..7586076b9bc5 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml @@ -0,0 +1,33 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/allwinner,sun20i-d1-codec-analog.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner D1 Analog Codec + +maintainers: + - Maksim Kiselev <bigunclemax@gmail.com> + +properties: + compatible: + const: allwinner,sun20i-d1-codec-analog + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + codec_analog: codec-analog@2030300 { + compatible = "allwinner,sun20i-d1-codec-analog"; + reg = <0x02030300 0xd00>; + }; + +... +
Add a DT schema to describe the analog part of the Allwinner D1/T113s internal audio codec. Signed-off-by: Maksim Kiselev <bigunclemax@gmail.com> --- .../allwinner,sun20i-d1-codec-analog.yaml | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun20i-d1-codec-analog.yaml