| Message ID | 20230726192740.1383740-2-iwona.winiarska@intel.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for PECI Nuvoton | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 26/07/2023 21:27, Iwona Winiarska wrote: > From: Tomer Maimon <tmaimon77@gmail.com> > > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > Changes v1 -> v2: > > * Renamed binding filename to match compatible (Krzysztof) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote: > From: Tomer Maimon <tmaimon77@gmail.com> > > Add device tree bindings for the peci-npcm controller driver. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > Changes v1 -> v2: > > * Renamed binding filename to match compatible (Krzysztof) > --- > .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/peci/peci-npcm.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230726192740.1383740-2-iwona.winiarska@intel.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 26/07/2023 21:39, Krzysztof Kozlowski wrote: > On 26/07/2023 21:27, Iwona Winiarska wrote: >> From: Tomer Maimon <tmaimon77@gmail.com> >> >> Add device tree bindings for the peci-npcm controller driver. >> >> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> >> Signed-off-by: Tyrone Ting <warp5tw@gmail.com> >> Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> >> Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> >> --- >> Changes v1 -> v2: >> >> * Renamed binding filename to match compatible (Krzysztof) > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Un-reviewed. Why testing the code before sending to LKML? Obviously not needed. Best regards, Krzysztof
On Wed, 2023-07-26 at 14:14 -0600, Rob Herring wrote: > > On Wed, 26 Jul 2023 21:27:37 +0200, Iwona Winiarska wrote: > > From: Tomer Maimon <tmaimon77@gmail.com> > > > > Add device tree bindings for the peci-npcm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > Signed-off-by: Tyrone Ting <warp5tw@gmail.com> > > Co-developed-by: Iwona Winiarska <iwona.winiarska@intel.com> > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > > --- > > Changes v1 -> v2: > > > > * Renamed binding filename to match compatible (Krzysztof) > > --- > > .../bindings/peci/nuvoton,npcm-peci.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/peci/nuvoton,npcm- > > peci.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml: $id: > Cannot determine base path from $id, relative path/filename doesn't match > actual path or filename > $id: http://devicetree.org/schemas/peci/peci-npcm.yaml > file: /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml Oops, sorry about that - I'll send v3. Thanks -Iwona > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230726192740.1383740-2-iwona.winiarska@intel.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
diff --git a/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml b/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml new file mode 100644 index 000000000000..6eafa9ccaa54 --- /dev/null +++ b/Documentation/devicetree/bindings/peci/nuvoton,npcm-peci.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/peci/peci-npcm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton PECI Bus + +maintainers: + - Tomer Maimon <tmaimon77@gmail.com> + +allOf: + - $ref: peci-controller.yaml# + +properties: + compatible: + enum: + - nuvoton,npcm750-peci + - nuvoton,npcm845-peci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + description: + Clock source for PECI controller. Should reference the APB clock. + maxItems: 1 + + cmd-timeout-ms: + minimum: 1 + maximum: 1000 + default: 1000 + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/nuvoton,npcm7xx-clock.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + peci-controller@f0100000 { + compatible = "nuvoton,npcm750-peci"; + reg = <0xf0100000 0x200>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk NPCM7XX_CLK_APB3>; + cmd-timeout-ms = <1000>; + }; +...