| Message ID | 20230724063520.182888-2-alexander.stein@ew.tq-group.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2,1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 24/07/2023 08:35, Alexander Stein wrote: > This is a gpio-controller, so gpio-line-names should be allowed as well. > pca9532 supports up to 16 GPIOs. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes in v2: > * Add min/maxItems > > Documentation/devicetree/bindings/leds/nxp,pca953x.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml > index edf6f55df685..9610bca57dd5 100644 > --- a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml > +++ b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml > @@ -29,6 +29,10 @@ properties: > > gpio-controller: true > > + gpio-line-names: > + minItems: 1 GPIO expander which adds only one GPIO? That would be weird. Are sure? Which model supports 1 GPIO? Best regards, Krzysztof
On 24/07/2023 08:35, Alexander Stein wrote: > This is a gpio-controller, so gpio-line-names should be allowed as well. > pca9532 supports up to 16 GPIOs. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Jul 24, 2023 at 8:35 AM Alexander Stein <alexander.stein@ew.tq-group.com> wrote: > This is a gpio-controller, so gpio-line-names should be allowed as well. > pca9532 supports up to 16 GPIOs. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, 24 Jul 2023 08:35:20 +0200, Alexander Stein wrote: > This is a gpio-controller, so gpio-line-names should be allowed as well. > pca9532 supports up to 16 GPIOs. > > Applied, thanks! [2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO commit: 4aa8f7e24f07669d27945149a72903bc032fa6e9 -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml index edf6f55df685..9610bca57dd5 100644 --- a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml +++ b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml @@ -29,6 +29,10 @@ properties: gpio-controller: true + gpio-line-names: + minItems: 1 + maxItems: 16 + '#gpio-cells': const: 2
This is a gpio-controller, so gpio-line-names should be allowed as well. pca9532 supports up to 16 GPIOs. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changes in v2: * Add min/maxItems Documentation/devicetree/bindings/leds/nxp,pca953x.yaml | 4 ++++ 1 file changed, 4 insertions(+)