| Message ID | 20230621094545.707-1-dylan_hung@aspeedtech.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: clock: ast2600: Add I3C and MAC reset definitions | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 21/06/2023 11:45, Dylan Hung wrote: > Add reset definitions of AST2600 I3C and MAC controllers. > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > --- > include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h > index e149eee61588..07377589f8f4 100644 > --- a/include/dt-bindings/clock/ast2600-clock.h > +++ b/include/dt-bindings/clock/ast2600-clock.h > @@ -90,7 +90,18 @@ > /* Only list resets here that are not part of a clock gate + reset pair */ > #define ASPEED_RESET_ADC 55 > #define ASPEED_RESET_JTAG_MASTER2 54 > -#define ASPEED_RESET_I3C_DMA 39 This will break all the users. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: Wednesday, June 21, 2023 6:11 PM > To: Dylan Hung <dylan_hung@aspeedtech.com>; mturquette@baylibre.com; > sboyd@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: BMC-SW <BMC-SW@aspeedtech.com> > Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset > definitions > > On 21/06/2023 11:45, Dylan Hung wrote: > > Add reset definitions of AST2600 I3C and MAC controllers. > > > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > > --- > > include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/ast2600-clock.h > b/include/dt-bindings/clock/ast2600-clock.h > > index e149eee61588..07377589f8f4 100644 > > --- a/include/dt-bindings/clock/ast2600-clock.h > > +++ b/include/dt-bindings/clock/ast2600-clock.h > > @@ -90,7 +90,18 @@ > > /* Only list resets here that are not part of a clock gate + reset pair */ > > #define ASPEED_RESET_ADC 55 > > #define ASPEED_RESET_JTAG_MASTER2 54 > > -#define ASPEED_RESET_I3C_DMA 39 > > This will break all the users. > > Best regards, > Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] > Sent: Wednesday, June 21, 2023 6:11 PM > To: Dylan Hung <dylan_hung@aspeedtech.com>; mturquette@baylibre.com; > sboyd@kernel.org; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org > Cc: BMC-SW <BMC-SW@aspeedtech.com> > Subject: Re: [PATCH] dt-bindings: clock: ast2600: Add I3C and MAC reset > definitions > > On 21/06/2023 11:45, Dylan Hung wrote: > > Add reset definitions of AST2600 I3C and MAC controllers. > > > > Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > > --- > > include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/include/dt-bindings/clock/ast2600-clock.h > b/include/dt-bindings/clock/ast2600-clock.h > > index e149eee61588..07377589f8f4 100644 > > --- a/include/dt-bindings/clock/ast2600-clock.h > > +++ b/include/dt-bindings/clock/ast2600-clock.h > > @@ -90,7 +90,18 @@ > > /* Only list resets here that are not part of a clock gate + reset pair */ > > #define ASPEED_RESET_ADC 55 > > #define ASPEED_RESET_JTAG_MASTER2 54 > > -#define ASPEED_RESET_I3C_DMA 39 > > This will break all the users. > This define was created but never used. However, if you have concerns about it, I can include it back in V2. > Best regards, > Krzysztof
diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h index e149eee61588..07377589f8f4 100644 --- a/include/dt-bindings/clock/ast2600-clock.h +++ b/include/dt-bindings/clock/ast2600-clock.h @@ -90,7 +90,18 @@ /* Only list resets here that are not part of a clock gate + reset pair */ #define ASPEED_RESET_ADC 55 #define ASPEED_RESET_JTAG_MASTER2 54 -#define ASPEED_RESET_I3C_DMA 39 + +#define ASPEED_RESET_MAC4 53 +#define ASPEED_RESET_MAC3 52 + +#define ASPEED_RESET_I3C5 45 +#define ASPEED_RESET_I3C4 44 +#define ASPEED_RESET_I3C3 43 +#define ASPEED_RESET_I3C2 42 +#define ASPEED_RESET_I3C1 41 +#define ASPEED_RESET_I3C0 40 +#define ASPEED_RESET_I3C 39 + #define ASPEED_RESET_PWM 37 #define ASPEED_RESET_PECI 36 #define ASPEED_RESET_MII 35
Add reset definitions of AST2600 I3C and MAC controllers. Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> --- include/dt-bindings/clock/ast2600-clock.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)