| Message ID | 20230621093103.3134655-2-msp@baylibre.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | can: tcan4x5x: Introduce tcan4552/4553 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > These two new chips do not have state or wake pins. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > --- > .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > index e3501bfa22e9..170e23f0610d 100644 > --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt > @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller > This file provides device node information for the TCAN4x5x interface contains. > > Required properties: > - - compatible: "ti,tcan4x5x" > + - compatible: > + "ti,tcan4552", "ti,tcan4x5x" > + "ti,tcan4553", "ti,tcan4x5x" or > + "ti,tcan4x5x" One more example why wildcards are not allowed. Ehh, Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > These two new chips do not have state or wake pins. > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> BTW, why did you ignore the tag? This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
Hi Krzysztof, On Wed, Jun 21, 2023 at 12:29:40PM +0200, Krzysztof Kozlowski wrote: > On 21/06/2023 11:30, Markus Schneider-Pargmann wrote: > > These two new chips do not have state or wake pins. > > > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> > > BTW, why did you ignore the tag? Thanks for your Acked-by. I did not add it from v1 because: - We had a long discussion after you sent your tag - I changed the binding documentation according to the discussion on v1 as stated in the cover letter: "- Update the binding documentation to specify tcan4552 and tcan4553 with the tcan4x5x as fallback" Thanks, Markus
diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt index e3501bfa22e9..170e23f0610d 100644 --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt @@ -4,7 +4,10 @@ Texas Instruments TCAN4x5x CAN Controller This file provides device node information for the TCAN4x5x interface contains. Required properties: - - compatible: "ti,tcan4x5x" + - compatible: + "ti,tcan4552", "ti,tcan4x5x" + "ti,tcan4553", "ti,tcan4x5x" or + "ti,tcan4x5x" - reg: 0 - #address-cells: 1 - #size-cells: 0 @@ -21,8 +24,10 @@ Optional properties: - reset-gpios: Hardwired output GPIO. If not defined then software reset. - device-state-gpios: Input GPIO that indicates if the device is in - a sleep state or if the device is active. - - device-wake-gpios: Wake up GPIO to wake up the TCAN device. + a sleep state or if the device is active. Not + available with tcan4552/4553. + - device-wake-gpios: Wake up GPIO to wake up the TCAN device. Not + available with tcan4552/4553. Example: tcan4x5x: tcan4x5x@0 {
These two new chips do not have state or wake pins. Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com> --- .../devicetree/bindings/net/can/tcan4x5x.txt | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)