| Message ID | 20230620070849.2059451-1-huqiang.qin@amlogic.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | dt-bindings: interrupt-controller: New binding for Meson-C3 SoCs | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On 20/06/2023 09:08, Huqiang Qin wrote: > Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs > > Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> > --- > .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt > index bde63f8f090e..fdea0488a98c 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt > @@ -19,6 +19,7 @@ Required properties: > "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3) > "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L) > "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2) > + "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X) Where is the user? If there is going to be resend/new version: A nit, subject: drop second/last, redundant "New binding for". The "dt-bindings" prefix is already stating that these are bindings. "Add Meson C3 SoC interrupt controller" Best regards, Krzysztof
On 20/06/2023 09:34, Krzysztof Kozlowski wrote: > On 20/06/2023 09:08, Huqiang Qin wrote: >> Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs >> >> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> >> --- >> .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >> index bde63f8f090e..fdea0488a98c 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt >> @@ -19,6 +19,7 @@ Required properties: >> "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3) >> "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L) >> "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2) >> + "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X) > > Where is the user? > > If there is going to be resend/new version: > A nit, subject: drop second/last, redundant "New binding for". The > "dt-bindings" prefix is already stating that these are bindings. > "Add Meson C3 SoC interrupt controller" And the bindings was updated to yaml and merged for v6.5, please rebase on: https://lore.kernel.org/all/e06e9f26-cf55-5596-c799-d698e9d7b409@gmail.com/ Neil > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt index bde63f8f090e..fdea0488a98c 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt @@ -19,6 +19,7 @@ Required properties: "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3) "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L) "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2) + "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X) - reg : Specifies base physical address and size of the registers. - interrupt-controller : Identifies the node as an interrupt controller. - #interrupt-cells : Specifies the number of cells needed to encode an
Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> --- .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt | 1 + 1 file changed, 1 insertion(+)