| Message ID | 20230609132915.634338-2-alexander.stein@ew.tq-group.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | TQMa93xxLA support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 09/06/2023 15:29, Alexander Stein wrote: > From: Markus Niebel <Markus.Niebel@ew.tq-group.com> > > TQMa93xxLA is a SOM variant in the TQ-Systems GmbH TQMa93xx series using > NXP i.MX93 CPU on an LGA type board. > MBa93xxCA is a starterkit base board for TQMa93xxLA on an adapter board. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. It is dt-bindings, not something else. A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. One bindings is enough. > > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../devicetree/bindings/arm/fsl.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 2510eaa8906dd..8048c7f6a299d 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1219,6 +1219,25 @@ properties: > - fsl,imxrt1170-evk # i.MXRT1170 EVK Board > - const: fsl,imxrt1170 > > + - description: > + TQMa93xxLA and TQMa93xxCA are two series of feature compatible SOM > + using NXP i.MX93 SOC in 11x11 mm package. > + TQMa93xxLA is designed to be soldered on different carrier boards. > + TQMa93xxCA is a compatible variant using board to board connectors. > + All SOM and CPU variants use the same device tree hence only one > + compatible is needed. Bootloader disables all features not present > + in the assembled SOC. > + MBa93xxCA mainboard can be used as starterkit for the SOM > + soldered on an adapter board or for the connector variant > + MBa93xxLA mainboard is a single board computer using the solderable > + SOM variant > + items: > + - enum: > + - tq,imx93-tqma9352-mba93xxca # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM on MBa93xxCA > + - tq,imx93-tqma9352-mba93xxla # TQ-Systems GmbH i.MX93 TQMa93xxLA SOM on MBa93xxLA SBC xx sound like wildcard which you should not use. If you open the product page, it also suggests that. Best regards, Krzysztof
Hi, Am Freitag, 9. Juni 2023, 17:58:17 CEST schrieb Krzysztof Kozlowski: > On 09/06/2023 15:29, Alexander Stein wrote: > > From: Markus Niebel <Markus.Niebel@ew.tq-group.com> > > > > TQMa93xxLA is a SOM variant in the TQ-Systems GmbH TQMa93xx series using > > NXP i.MX93 CPU on an LGA type board. > > MBa93xxCA is a starterkit base board for TQMa93xxLA on an adapter board. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > It is dt-bindings, not something else. > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. One > bindings is enough. Thanks. I'll update that. > > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > .../devicetree/bindings/arm/fsl.yaml | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml index > > 2510eaa8906dd..8048c7f6a299d 100644 > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > > @@ -1219,6 +1219,25 @@ properties: > > - fsl,imxrt1170-evk # i.MXRT1170 EVK Board > > > > - const: fsl,imxrt1170 > > > > + - description: > > + TQMa93xxLA and TQMa93xxCA are two series of feature compatible > > SOM + using NXP i.MX93 SOC in 11x11 mm package. > > + TQMa93xxLA is designed to be soldered on different carrier > > boards. + TQMa93xxCA is a compatible variant using board to > > board connectors. + All SOM and CPU variants use the same device > > tree hence only one + compatible is needed. Bootloader disables > > all features not present + in the assembled SOC. > > + MBa93xxCA mainboard can be used as starterkit for the SOM > > + soldered on an adapter board or for the connector variant > > + MBa93xxLA mainboard is a single board computer using the > > solderable + SOM variant > > + items: > > + - enum: > > + - tq,imx93-tqma9352-mba93xxca # TQ-Systems GmbH i.MX93 > > TQMa93xxCA/LA SOM on MBa93xxCA + - > > tq,imx93-tqma9352-mba93xxla # TQ-Systems GmbH i.MX93 TQMa93xxLA SOM on > > MBa93xxLA SBC > xx sound like wildcard which you should not use. If you open the product > page, it also suggests that. xx is a wildcard only for modules TQMa93xx, depending on the soldered SoC, but not for the mainboard MBa93xx. You are right that there is the ordering number MBa9352LA-AA, so the compatible would be "tq,imx93-tqma9352-mba9352la". But the actual values for the wildcards is copied from the soldered module. So using a TQMa9351LA would result in MBa9351LA-AA, although the mainboard is identical. Best regards, Alexander > Best regards, > Krzysztof
On 15/06/2023 16:46, Alexander Stein wrote: >>> + TQMa93xxLA and TQMa93xxCA are two series of feature compatible >>> SOM + using NXP i.MX93 SOC in 11x11 mm package. >>> + TQMa93xxLA is designed to be soldered on different carrier >>> boards. + TQMa93xxCA is a compatible variant using board to >>> board connectors. + All SOM and CPU variants use the same device >>> tree hence only one + compatible is needed. Bootloader disables >>> all features not present + in the assembled SOC. >>> + MBa93xxCA mainboard can be used as starterkit for the SOM >>> + soldered on an adapter board or for the connector variant >>> + MBa93xxLA mainboard is a single board computer using the >>> solderable + SOM variant >>> + items: >>> + - enum: >>> + - tq,imx93-tqma9352-mba93xxca # TQ-Systems GmbH i.MX93 >>> TQMa93xxCA/LA SOM on MBa93xxCA + - >>> tq,imx93-tqma9352-mba93xxla # TQ-Systems GmbH i.MX93 TQMa93xxLA SOM on >>> MBa93xxLA SBC >> xx sound like wildcard which you should not use. If you open the product >> page, it also suggests that. > > xx is a wildcard only for modules TQMa93xx, depending on the soldered SoC, but > not for the mainboard MBa93xx. > You are right that there is the ordering number MBa9352LA-AA, so the > compatible would be "tq,imx93-tqma9352-mba9352la". But the actual values for > the wildcards is copied from the soldered module. So using a TQMa9351LA would > result in MBa9351LA-AA, although the mainboard is identical. OK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 2510eaa8906dd..8048c7f6a299d 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1219,6 +1219,25 @@ properties: - fsl,imxrt1170-evk # i.MXRT1170 EVK Board - const: fsl,imxrt1170 + - description: + TQMa93xxLA and TQMa93xxCA are two series of feature compatible SOM + using NXP i.MX93 SOC in 11x11 mm package. + TQMa93xxLA is designed to be soldered on different carrier boards. + TQMa93xxCA is a compatible variant using board to board connectors. + All SOM and CPU variants use the same device tree hence only one + compatible is needed. Bootloader disables all features not present + in the assembled SOC. + MBa93xxCA mainboard can be used as starterkit for the SOM + soldered on an adapter board or for the connector variant + MBa93xxLA mainboard is a single board computer using the solderable + SOM variant + items: + - enum: + - tq,imx93-tqma9352-mba93xxca # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM on MBa93xxCA + - tq,imx93-tqma9352-mba93xxla # TQ-Systems GmbH i.MX93 TQMa93xxLA SOM on MBa93xxLA SBC + - const: tq,imx93-tqma9352 # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM + - const: fsl,imx93 + - description: Freescale Vybrid Platform Device Tree Bindings