| Message ID | 20230605074753.562332-3-javierm@redhat.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drm/ssd130x: A few enhancements and cleanups | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
Hi, On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote: > A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > anymore. Instead is set to a width and height that's controller dependent. > > Update DT schema to reflect what the driver does and make its users aware. > > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > .../devicetree/bindings/display/solomon,ssd1307fb.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > index 94bb5ef567c6..e8ed642dc144 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml > @@ -49,15 +49,15 @@ properties: > > solomon,height: > $ref: /schemas/types.yaml#/definitions/uint32 > - default: 16 > description: > - Height in pixel of the screen driven by the controller > + Height in pixel of the screen driven by the controller. > + The default value is controller-dependent. > > solomon,width: > $ref: /schemas/types.yaml#/definitions/uint32 > - default: 96 > description: > - Width in pixel of the screen driven by the controller > + Width in pixel of the screen driven by the controller. > + The default value is controller-dependent. I think we should document it still, either in the comment itself, or through a conditional and different default values based on the compatible. Maxime
Maxime Ripard <mripard@kernel.org> writes: Hello Maxime, Thanks for your feedback. > Hi, > > On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote: [...] >> solomon,width: >> $ref: /schemas/types.yaml#/definitions/uint32 >> - default: 96 >> description: >> - Width in pixel of the screen driven by the controller >> + Width in pixel of the screen driven by the controller. >> + The default value is controller-dependent. > > I think we should document it still, either in the comment itself, or > through a conditional and different default values based on the > compatible. > Makes sense. I'll add that in v2.
diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml index 94bb5ef567c6..e8ed642dc144 100644 --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml @@ -49,15 +49,15 @@ properties: solomon,height: $ref: /schemas/types.yaml#/definitions/uint32 - default: 16 description: - Height in pixel of the screen driven by the controller + Height in pixel of the screen driven by the controller. + The default value is controller-dependent. solomon,width: $ref: /schemas/types.yaml#/definitions/uint32 - default: 96 description: - Width in pixel of the screen driven by the controller + Width in pixel of the screen driven by the controller. + The default value is controller-dependent. solomon,page-offset: $ref: /schemas/types.yaml#/definitions/uint32
A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 anymore. Instead is set to a width and height that's controller dependent. Update DT schema to reflect what the driver does and make its users aware. Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- .../devicetree/bindings/display/solomon,ssd1307fb.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)