| Message ID | 20230602133714.260556-1-raymondhackley@protonmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | leds: sgm3140: Add richtek,rt5033-led compatible | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 02/06/2023 15:38, Raymond Hackley wrote: > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > camera flash LEDs. What are the similarities? Same register interface? Same pins? It's not obvious and your commit should clear explain this. It will be also justification why you did not make devices compatible. Best regards, Krzysztof
I've not seen this because Protonmail has encoded your mail. On Fri, 02 Jun 2023, Raymond Hackley wrote: > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > camera flash LEDs. > > Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> > --- > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > index 4d2ffe5fcfc7..37d2a93780ab 100644 > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml > @@ -20,6 +20,7 @@ properties: > compatible: > enum: > - ocs,ocp8110 > + - richtek,rt5033-led > - sgmicro,sgm3140 > > enable-gpios: > -- > 2.30.2 > >
Hi Krzysztof, On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 02/06/2023 15:38, Raymond Hackley wrote: > > > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for > > camera flash LEDs. > > > What are the similarities? Same register interface? Same pins? It's not > obvious and your commit should clear explain this. It will be also > justification why you did not make devices compatible. > There is a similar way to control with 2 GPIO pins, strobe and enable, which is not described well in this patch set. Regards, Raymond
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml index 4d2ffe5fcfc7..37d2a93780ab 100644 --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml @@ -20,6 +20,7 @@ properties: compatible: enum: - ocs,ocp8110 + - richtek,rt5033-led - sgmicro,sgm3140 enable-gpios:
Add devicetree binding for Richtek RT5033 Flash LED charge pump used for camera flash LEDs. Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com> --- Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 + 1 file changed, 1 insertion(+)