| Message ID | 20230602020502.11693-1-hayashi.kunihiko@socionext.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | of: overlay: Fix missing of_node_put() in error case of init_overlay_changeset() | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | fail | build log |
On Fri, 02 Jun 2023 11:05:02 +0900, Kunihiko Hayashi wrote: > In init_overlay_changeset(), the variable "node" is from > of_get_child_by_name(), and the "node" should be discarded in error case. > > Fixes: d1651b03c2df ("of: overlay: add overlay symbols to live device tree") > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > drivers/of/overlay.c | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks!
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 2e01960f1aeb..7feb643f1370 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -811,6 +811,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs) if (!fragment->target) { pr_err("symbols in overlay, but not in live tree\n"); ret = -EINVAL; + of_node_put(node); goto err_out; }
In init_overlay_changeset(), the variable "node" is from of_get_child_by_name(), and the "node" should be discarded in error case. Fixes: d1651b03c2df ("of: overlay: add overlay symbols to live device tree") Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- drivers/of/overlay.c | 1 + 1 file changed, 1 insertion(+)