| Message ID | 20230601053546.9574-9-nikita.shubin@maquefel.me |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | ep93xx device tree conversion | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 01/06/2023 07:33, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > timer block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > Fix versioning. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 01/06/2023 07:33, Nikita Shubin wrote: > This adds device tree bindings for the Cirrus Logic EP93xx > timer block used in these SoCs. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > > Notes: > v0 -> v1: > - as Hartley (unfortunately) looks like not interested in dt rework, > added myself instead > > Krzysztof Kozlowski: > - removed wildcards > - use fallback compatible and list all possible compatibles > - fix ident > - dropped bindings in title I gave you already the tag. I also explained in lengthy message what to do with it, yet you did not include it here. I'll stop the review. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep9301-timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep9301-timer.yaml new file mode 100644 index 000000000000..e463e11e259d --- /dev/null +++ b/Documentation/devicetree/bindings/timer/cirrus,ep9301-timer.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/cirrus,ep9301-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cirrus Logic EP93xx timer + +maintainers: + - Alexander Sverdlin <alexander.sverdlin@gmail.com> + - Nikita Shubin <nikita.shubin@maquefel.me> + +properties: + compatible: + oneOf: + - const: cirrus,ep9301-timer + - items: + - enum: + - cirrus,ep9302-timer + - cirrus,ep9307-timer + - cirrus,ep9312-timer + - cirrus,ep9315-timer + - const: cirrus,ep9301-timer + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + timer@80810000 { + compatible = "cirrus,ep9301-timer"; + reg = <0x80810000 0x100>; + interrupt-parent = <&vic1>; + interrupts = <19>; + }; +...
This adds device tree bindings for the Cirrus Logic EP93xx timer block used in these SoCs. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- Notes: v0 -> v1: - as Hartley (unfortunately) looks like not interested in dt rework, added myself instead Krzysztof Kozlowski: - removed wildcards - use fallback compatible and list all possible compatibles - fix ident - dropped bindings in title .../bindings/timer/cirrus,ep9301-timer.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/cirrus,ep9301-timer.yaml