[v2,2/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board

Add bindings for the compatible string used for the TP-Link's
HC220 G5 V1 board, a wireless AP based on MT7621.

Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
---
 Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
 1 file changed, 1 insertion(+)

Hey,

On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote:
> Add bindings for the compatible string used for the TP-Link's
> HC220 G5 V1 board, a wireless AP based on MT7621.
> 
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>

Two process things:
- Please run get_maintainer.pl against the current git tree - you seem
  to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
  omission, but omitting Krzysztof means you're submitting patches based
  on a tree that is over a year old.
- Please don't send a v2 in reply to the v1.

> ---
>  Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
> index 704b5b5951271..53c1f66353770 100644
> --- a/Documentation/devicetree/bindings/mips/ralink.yaml
> +++ b/Documentation/devicetree/bindings/mips/ralink.yaml
> @@ -80,6 +80,7 @@ properties:
>            - enum:
>                - gnubee,gb-pc1
>                - gnubee,gb-pc2
> +              - tplink,hc220-g5-v1

For the actual change though,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

>            - const: mediatek,mt7621-soc
>  
>  additionalProperties: true
> -- 
> 2.40.1
>

On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote:
> Hey,

Hi Conor,

> 
> On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote:
> > Add bindings for the compatible string used for the TP-Link's
> > HC220 G5 V1 board, a wireless AP based on MT7621.
> > 
> > Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> 
> Two process things:
> - Please run get_maintainer.pl against the current git tree - you seem
>   to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
>   omission, but omitting Krzysztof means you're submitting patches based
>   on a tree that is over a year old.

Appologies for that, I should have check get_maintainer.pl rather than looking
at the output of git log for the file.

> - Please don't send a v2 in reply to the v1.

Sorry, I'm not sure why that makes any difference. Reason for sending it as a
reply was the fact that last conversation was more than two weeks ago, people
might have forgot the context. This way it's all in one thread.

> 
> > ---
> >  Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
> > index 704b5b5951271..53c1f66353770 100644
> > --- a/Documentation/devicetree/bindings/mips/ralink.yaml
> > +++ b/Documentation/devicetree/bindings/mips/ralink.yaml
> > @@ -80,6 +80,7 @@ properties:
> >            - enum:
> >                - gnubee,gb-pc1
> >                - gnubee,gb-pc2
> > +              - tplink,hc220-g5-v1
> 
> For the actual change though,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Many thanks!

Best regards,
Liviu

> 
> Thanks,
> Conor.
> 
> >            - const: mediatek,mt7621-soc
> >  
> >  additionalProperties: true
> > -- 
> > 2.40.1
> >

On Mon, May 29, 2023 at 10:53:57PM +0100, Liviu Dudau wrote:
> On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote:

> > Two process things:
> > - Please run get_maintainer.pl against the current git tree - you seem
> >   to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
> >   omission, but omitting Krzysztof means you're submitting patches based
> >   on a tree that is over a year old.
> 
> Appologies for that, I should have check get_maintainer.pl rather than looking
> at the output of git log for the file.

Yeah, git log ain't the way to do things ;)

> 
> > - Please don't send a v2 in reply to the v1.
> 
> Sorry, I'm not sure why that makes any difference. Reason for sending it as a
> reply was the fact that last conversation was more than two weeks ago, people
> might have forgot the context. This way it's all in one thread.

That's fine, just include a link to v1 on lore for anyone that cares
about the context, like so:
https://lore.kernel.org/all/20230529150833.526084-1-liviu@dudau.co.uk/

I knew this mail had been sent today because I noticed at the time that
you'd only CCed Rob but I remembered nothing of the subject line since
I saw it hours ago. Look how far back in my mailbox it ended up because
of being sent as a reply to the v1, and that mailbox only contains
emails from the devicetree list!

4380     May 29 Liviu Dudau     (7.6K) │       ┌─>[PATCH v2 1/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
4381   T May 29 Liviu Dudau     (5.8K) │       │   ┌─>
4382  sF May 29 To Liviu Dudau  (6.8K) │       │ ┌─>
4383     May 29 Liviu Dudau     (4.6K) │       ├─>[PATCH v2 2/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board
4384     May 29 Liviu Dudau     (4.7K) │     ┌─>[PATCH v2 0/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
4385     May 12 Arınç ÜNAL      ( 12K) │   ┌─>
4386     May 11 Liviu Dudau     ( 10K) │ ┌─>
4387     May 11 Arınç ÜNAL      ( 10K) ├─>
4388     May 09 Liviu Dudau     (7.8K) [PATCH] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board.

Some patch application & CI tools apparently also get confused, but I
dunno what those tools are.

Cheers,
Conor.

On Mon, May 29, 2023 at 5:08 PM Liviu Dudau <liviu@dudau.co.uk> wrote:
>
> Add bindings for the compatible string used for the TP-Link's
> HC220 G5 V1 board, a wireless AP based on MT7621.
>
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> ---
>  Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thanks,
    Sergio Paracuellos