| Message ID | 20230528001010.47868-2-guptarud@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Samsung Galaxy Express SGH-I437 Support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
> Where did the "att" come from in the compatible. Is this some carrier
specific model of the phone?
This is the code name for the device. Since there are usually multiple
variants of a device, using the code name differentiates between those
variants. For example, if I left this as "samsung,express", it would be
unclear if I am referring to the GT-I8730 (code name: expresslte) or the
SGH-I437 model. This is typically done in postmarketOS:
https://wiki.postmarketos.org/wiki/Devices and XDA developers. I believe
it is a carrier specific model of the Samsung Galaxy Express.
On 28.05.2023 15:36, Rudraksha Gupta wrote: >> Where did the "att" come from in the compatible. Is this some carrier specific model of the phone? > > This is the code name for the device. Since there are usually multiple variants of a device, using the code name differentiates between those variants. For example, if I left this as "samsung,express", it would be unclear if I am referring to the GT-I8730 (code name: expresslte) or the SGH-I437 model. This is typically done in postmarketOS: https://wiki.postmarketos.org/wiki/Devices and XDA developers. I believe it is a carrier specific model of the Samsung Galaxy Express. > Please fix your email client: - wrap each line at about 80 characters - don't trim messages unless they're very long or there's some other good reason - Don't send v(n+1) as a reply to v(n), send it in a separate thread. Konrad
On Mon May 29, 2023 at 3:41 AM EDT, Konrad Dybcio wrote: > > > On 28.05.2023 15:36, Rudraksha Gupta wrote: > >> Where did the "att" come from in the compatible. Is this some carrier specific model of the phone? > > > > This is the code name for the device. Since there are usually multiple variants of a device, using the code name differentiates between those variants. For example, if I left this as "samsung,express", it would be unclear if I am referring to the GT-I8730 (code name: expresslte) or the SGH-I437 model. This is typically done in postmarketOS: https://wiki.postmarketos.org/wiki/Devices and XDA developers. I believe it is a carrier specific model of the Samsung Galaxy Express. > > > > Please fix your email client: > > - wrap each line at about 80 characters > - don't trim messages unless they're very long or > there's some other good reason > - Don't send v(n+1) as a reply to v(n), send it in a > separate thread. > Gotcha, I will do that next time. Should I still send v2 in a separate thread? Not sure if I should as I don't want to spam anyone. > > > Konrad
On Mon May 29, 2023 at 6:37 PM EDT, Conor Dooley wrote: > On Mon, May 29, 2023 at 06:28:05PM -0400, Rudraksha Gupta wrote: > > > Gotcha, I will do that next time. Should I still send v2 in a separate > > thread? > > That'd then be either [PATCH v3], or [RESEND PATCH v2]. Ideally v3 since > you will have added the tags you received on v2. > AFAIK Bjorn uses b4, which should be able to deal with the series as-is, > but sending a v3 with the Acks etc would not be a bad idea. You > should probably give it a couple days before doing that to see if it > gets picked up before doing that. > > > Not sure if I should as I don't want to spam anyone. > > Sending new revisions of patches as a new thread is not spamming, we > signed up to be maintainers, or get to email from the lists, after all. > Sending several revisions of the same patches in a day would be spamming > though, but that is not what we are talking about here ;) > > Cheers, > Conor. Ah, I see. Thank you for being patient with me. I'm really excited to see my patch go in! :)
On Sat, 27 May 2023 20:10:06 -0400, Rudraksha Gupta wrote: > Add a compatible for Samsung Galaxy Express SGH-I437. > > Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1786779 /: qcom,board-id: False schema does not allow [[8, 0]] arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dtb /: qcom,msm-id: False schema does not allow [[194, 65536]] arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dtb
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index d9dd25695c3d..133d69b2b73d 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -191,6 +191,7 @@ properties: - items: - enum: - qcom,msm8960-cdp + - samsung,expressatt - const: qcom,msm8960 - items:
Add a compatible for Samsung Galaxy Express SGH-I437. Signed-off-by: Rudraksha Gupta <guptarud@gmail.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 1 + 1 file changed, 1 insertion(+)