| Message ID | 20230524-pmi8998-charger-dts-v1-1-f9334afc4505@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Enable PMI8998 charger on supported devices | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Wed, 24 May 2023 18:38:52 +0100, Caleb Connolly wrote: > Document the new pmi8998 charger bindings > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/power/supply/qcom,pmi8998-charger.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230524-pmi8998-charger-dts-v1-1-f9334afc4505@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hey Caleb, On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote: > Document the new pmi8998 charger bindings This commit message looks a bit odd compared to the contents of the diff. Did you forget to git add something? Cheers, Conor. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index 36de335a33aa..44590dc112be 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -133,6 +133,7 @@ patternProperties: > oneOf: > - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# > - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# > + - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml# > > "gpio@[0-9a-f]+$": > type: object > > -- > 2.40.1 >
On 24/05/2023 20:02, Conor Dooley wrote: > Hey Caleb, > > On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote: >> Document the new pmi8998 charger bindings > > This commit message looks a bit odd compared to the contents of the > diff. Did you forget to git add something? Well, it's not my finest commit message... The binding is in the series linked in the cover letter (or [1]), I missed this addition when sending that. Would it be better to just squash this patch into the bindings and respin the other series? [1]: https://lore.kernel.org/linux-arm-msm/20230524-pmi8998-charger-v8-0-b87ffcd9864d@linaro.org/ > > Cheers, > Conor. > >> >> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index 36de335a33aa..44590dc112be 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -133,6 +133,7 @@ patternProperties: >> oneOf: >> - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# >> - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# >> + - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml# >> >> "gpio@[0-9a-f]+$": >> type: object >> >> -- >> 2.40.1 >>
On Wed, May 24, 2023 at 08:53:27PM +0100, Caleb Connolly wrote: > On 24/05/2023 20:02, Conor Dooley wrote: > > Hey Caleb, > > > > On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote: > >> Document the new pmi8998 charger bindings > > > > This commit message looks a bit odd compared to the contents of the > > diff. Did you forget to git add something? > > Well, it's not my finest commit message... The binding is in the series > linked in the cover letter (or [1]), I missed this addition when sending > that. Ya know, I opened the cover to check if there was something more specific said about this & somehow did not notice it. I guess the commit message & the bot report from Rob addled my brain. Sorry about that. > Would it be better to just squash this patch into the bindings and > respin the other series? I dunno chief. I am always loathe to tell people how they should submit stuff in these kind of scenarios, as I don't wanna send them up the garden path. But, that said, if they don't go via the same tree you're gonna end up creating the issue that the bot reported in whatever tree applies this patch without the other. ¯\_(ツ)_/¯ Cheers, Conor
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 36de335a33aa..44590dc112be 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -133,6 +133,7 @@ patternProperties: oneOf: - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# + - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml# "gpio@[0-9a-f]+$": type: object
Document the new pmi8998 charger bindings Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + 1 file changed, 1 insertion(+)