| Message ID | 20230522125129.526604-1-festevam@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v5,1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 5/22/23 14:51, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add > some logic to reflect that. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v4: > - Replaced items: with const: for the single item (Conor) > > .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > index 07388bf2b90d..d97064140547 100644 > --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > @@ -28,12 +28,12 @@ properties: > const: ldb > > reg: > + minItems: 1 > maxItems: 2 > > reg-names: > - items: > - - const: ldb > - - const: lvds > + minItems: 1 > + maxItems: 2 > > ports: > $ref: /schemas/graph.yaml#/properties/ports > @@ -74,6 +74,26 @@ allOf: > properties: > port@2: false > > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-ldb > + then: > + properties: > + reg: > + maxItems: 1 > + reg-names: > + const: ldb Can we drop the reg-names on MX6SX if we have reg maxItems=1 here ? I think we can, but we need to retain that on the newer iMXes which have reg maxItems=2
On 5/22/23 14:51, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > i.MX6SX has an LVDS controller that is connected to the eLCDIF. > > Add support for it. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v4: > - None. > > arch/arm/boot/dts/imx6sx.dtsi | 39 +++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi > index 4233943a1cca..442106565025 100644 > --- a/arch/arm/boot/dts/imx6sx.dtsi > +++ b/arch/arm/boot/dts/imx6sx.dtsi > @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 { > gpr: iomuxc-gpr@20e4000 { > compatible = "fsl,imx6sx-iomuxc-gpr", > "fsl,imx6q-iomuxc-gpr", "syscon"; Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here.
On Mon, 22 May 2023 09:51:26 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > On the i.MX6SX there is a single entry for 'reg' and 'reg-names', so add > some logic to reflect that. > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > Changes since v4: > - Replaced items: with const: for the single item (Conor) > > .../bindings/display/bridge/fsl,ldb.yaml | 26 ++++++++++++++++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml:84:12: [warning] wrong indentation: expected 10 but found 11 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522125129.526604-1-festevam@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 22/05/2023 10:20, Marek Vasut wrote: >> diff --git a/arch/arm/boot/dts/imx6sx.dtsi >> b/arch/arm/boot/dts/imx6sx.dtsi >> index 4233943a1cca..442106565025 100644 >> --- a/arch/arm/boot/dts/imx6sx.dtsi >> +++ b/arch/arm/boot/dts/imx6sx.dtsi >> @@ -844,7 +844,38 @@ iomuxc: pinctrl@20e0000 { >> gpr: iomuxc-gpr@20e4000 { >> compatible = "fsl,imx6sx-iomuxc-gpr", >> "fsl,imx6q-iomuxc-gpr", "syscon"; > > Maybe this "fsl,imx6q-iomuxc-gpr" should be dropped here. Cannot remove it as it breaks PCI: imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml index 07388bf2b90d..d97064140547 100644 --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml @@ -28,12 +28,12 @@ properties: const: ldb reg: + minItems: 1 maxItems: 2 reg-names: - items: - - const: ldb - - const: lvds + minItems: 1 + maxItems: 2 ports: $ref: /schemas/graph.yaml#/properties/ports @@ -74,6 +74,26 @@ allOf: properties: port@2: false + - if: + properties: + compatible: + contains: + const: fsl,imx6sx-ldb + then: + properties: + reg: + maxItems: 1 + reg-names: + const: ldb + else: + properties: + reg: + minItems: 2 + reg-names: + items: + - const: ldb + - const: lvds + additionalProperties: false examples: