| Message ID | 20230517111534.32630-6-trevor.wu@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | ASoC: mt8188: add new board support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On 17/05/2023 13:15, Trevor Wu wrote: > Add compatible string "mediatek,mt8188-nau8825" to support new board > with nau8825 codec. Subject: everything can be update of properties. Rephrase to focus on actual change, e.g. on adding NAU8825. > > ADDA_BE is used to connect to mt6359. For the machine, it must be > fixed to the same codec and configured on the machine driver. Remove > ADDA_BE from items of link-name. I don't understand the justification for this. If this is not a correct link name for MT6359 setup, then it should be removed in its own patch. If this is removed because of adding NAU8825, then why does it affect MT6359? > > Introduce two properties "dai-format" and "mediatek,clk-provider" under > dai-link subnode to configure dai-link parameters via dts. > > "codec" property is removed from required property of dai-link subnode. > For co-clock case, it's possible two dai-links should be configured to > the same format, but only one dai-link builds link with codec. > > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> > --- > .../sound/mediatek,mt8188-mt6359.yaml | 27 ++++++++++++++++--- > 1 file changed, 23 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > index 6640272b3f4f..05e532b5d50a 100644 > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: mediatek,mt8188-mt6359-evb > + enum: > + - mediatek,mt8188-mt6359-evb > + - mediatek,mt8188-nau8825 > > model: > $ref: /schemas/types.yaml#/definitions/string > @@ -42,7 +44,6 @@ patternProperties: > we are going to update parameters in this node. > items: > enum: > - - ADDA_BE Best regards, Krzysztof
On Wed, 2023-05-17 at 16:43 +0200, Krzysztof Kozlowski wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On 17/05/2023 13:15, Trevor Wu wrote: > > Add compatible string "mediatek,mt8188-nau8825" to support new > > board > > with nau8825 codec. > > Subject: everything can be update of properties. Rephrase to focus on > actual change, e.g. on adding NAU8825. > OK. I will rename the topic in v2. > > > > ADDA_BE is used to connect to mt6359. For the machine, it must be > > fixed to the same codec and configured on the machine driver. > > Remove > > ADDA_BE from items of link-name. > > I don't understand the justification for this. If this is not a > correct > link name for MT6359 setup, then it should be removed in its own > patch. > If this is removed because of adding NAU8825, then why does it affect > MT6359? > In the patch series, [PATCH 1/5] divides ADDA_BE into UL_SRC_BE and DL_SRC_BE. I was going to replace the link name, but I found it shouldn't be configured for the machine, because mt6359 is the only codec for ADDA_BE and it's hardcoded in the machine driver. As a result, I decided to remove it. I will separate it from the patch, and put the new patch after [PATCH 1/5]. Thanks, Trevor > > > > Introduce two properties "dai-format" and "mediatek,clk-provider" > > under > > dai-link subnode to configure dai-link parameters via dts. > > > > "codec" property is removed from required property of dai-link > > subnode. > > For co-clock case, it's possible two dai-links should be configured > > to > > the same format, but only one dai-link builds link with codec. > > > > Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> > > --- > > .../sound/mediatek,mt8188-mt6359.yaml | 27 > > ++++++++++++++++--- > > 1 file changed, 23 insertions(+), 4 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/sound/mediatek,mt8188- > > mt6359.yaml > > b/Documentation/devicetree/bindings/sound/mediatek,mt8188- > > mt6359.yaml > > index 6640272b3f4f..05e532b5d50a 100644 > > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188- > > mt6359.yaml > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188- > > mt6359.yaml > > @@ -11,7 +11,9 @@ maintainers: > > > > properties: > > compatible: > > - const: mediatek,mt8188-mt6359-evb > > + enum: > > + - mediatek,mt8188-mt6359-evb > > + - mediatek,mt8188-nau8825 > > > > model: > > $ref: /schemas/types.yaml#/definitions/string > > @@ -42,7 +44,6 @@ patternProperties: > > we are going to update parameters in this node. > > items: > > enum: > > - - ADDA_BE > > > Best regards, > Krzysztof >
On 18/05/2023 04:37, Trevor Wu (吳文良) wrote: > On Wed, 2023-05-17 at 16:43 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 17/05/2023 13:15, Trevor Wu wrote: >>> Add compatible string "mediatek,mt8188-nau8825" to support new >>> board >>> with nau8825 codec. >> >> Subject: everything can be update of properties. Rephrase to focus on >> actual change, e.g. on adding NAU8825. >> > OK. I will rename the topic in v2. > >>> >>> ADDA_BE is used to connect to mt6359. For the machine, it must be >>> fixed to the same codec and configured on the machine driver. >>> Remove >>> ADDA_BE from items of link-name. >> >> I don't understand the justification for this. If this is not a >> correct >> link name for MT6359 setup, then it should be removed in its own >> patch. >> If this is removed because of adding NAU8825, then why does it affect >> MT6359? >> > > In the patch series, [PATCH 1/5] divides ADDA_BE into UL_SRC_BE and > DL_SRC_BE. I was going to replace the link name, but I found it > shouldn't be configured for the machine, because mt6359 is the only > codec for ADDA_BE and it's hardcoded in the machine driver. As a > result, I decided to remove it. > > I will separate it from the patch, and put the new patch after [PATCH > 1/5]. Yes, please. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml index 6640272b3f4f..05e532b5d50a 100644 --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml @@ -11,7 +11,9 @@ maintainers: properties: compatible: - const: mediatek,mt8188-mt6359-evb + enum: + - mediatek,mt8188-mt6359-evb + - mediatek,mt8188-nau8825 model: $ref: /schemas/types.yaml#/definitions/string @@ -42,7 +44,6 @@ patternProperties: we are going to update parameters in this node. items: enum: - - ADDA_BE - DPTX_BE - ETDM1_IN_BE - ETDM2_IN_BE @@ -62,11 +63,28 @@ patternProperties: required: - sound-dai + dai-format: + description: audio format. + items: + enum: + - i2s + - right_j + - left_j + - dsp_a + - dsp_b + + mediatek,clk-provider: + $ref: /schemas/types.yaml#/definitions/string + description: Indicates dai-link clock master. + items: + enum: + - cpu + - codec + additionalProperties: false required: - link-name - - codec additionalProperties: false @@ -87,7 +105,8 @@ examples: "AIN1", "Headset Mic"; dai-link-0 { link-name = "ETDM3_OUT_BE"; - + dai-format = "i2s"; + mediatek,clk-provider = "cpu"; codec { sound-dai = <&hdmi0>; };
Add compatible string "mediatek,mt8188-nau8825" to support new board with nau8825 codec. ADDA_BE is used to connect to mt6359. For the machine, it must be fixed to the same codec and configured on the machine driver. Remove ADDA_BE from items of link-name. Introduce two properties "dai-format" and "mediatek,clk-provider" under dai-link subnode to configure dai-link parameters via dts. "codec" property is removed from required property of dai-link subnode. For co-clock case, it's possible two dai-links should be configured to the same format, but only one dai-link builds link with codec. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> --- .../sound/mediatek,mt8188-mt6359.yaml | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-)