| Message ID | 20230517-topic-kailua-llcc-v1-1-d57bd860c43e@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Fix SM8550 LLCC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 7 lines checked |
| robh/patch-applied | success | |
| robh/dtbs-check | warning | build log |
| robh/dt-meta-schema | success |
On Wed, May 17, 2023 at 04:18:49AM +0200, Konrad Dybcio wrote: > SM8550 (LLCCv4.1) has 4 register regions, this was not described > between its addition and the restructurization that happened in > the commit referenced in the fixes tag. > > Fix it. > > Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") I'm not sure if the Fixes tag should point to the patch adding SM8550 support or the restructuring patch. > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> But the change LGTM! Acked-by: Manivannan Sadhasivam <mani@kernel.org> - Mani > --- > Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > index d8b91944180a..44892aa589fd 100644 > --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > @@ -129,6 +129,7 @@ allOf: > - qcom,sm8250-llcc > - qcom,sm8350-llcc > - qcom,sm8450-llcc > + - qcom,sm8550-llcc > then: > properties: > reg: > > -- > 2.40.1 >
On Wed, 17 May 2023 04:18:49 +0200, Konrad Dybcio wrote: > SM8550 (LLCCv4.1) has 4 register regions, this was not described > between its addition and the restructurization that happened in > the commit referenced in the fixes tag. > > Fix it. > > Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + > 1 file changed, 1 insertion(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1782401 system-cache-controller@25000000: reg: [[0, 620756992, 0, 8388608], [0, 629145600, 0, 2097152]] is too short arch/arm64/boot/dts/qcom/sm8550-mtp.dtb arch/arm64/boot/dts/qcom/sm8550-qrd.dtb system-cache-controller@25000000: reg-names:0: 'llcc0_base' was expected arch/arm64/boot/dts/qcom/sm8550-mtp.dtb arch/arm64/boot/dts/qcom/sm8550-qrd.dtb system-cache-controller@25000000: reg-names:1: 'llcc1_base' was expected arch/arm64/boot/dts/qcom/sm8550-mtp.dtb arch/arm64/boot/dts/qcom/sm8550-qrd.dtb system-cache-controller@25000000: reg-names: ['llcc_base', 'llcc_broadcast_base'] is too short arch/arm64/boot/dts/qcom/sm8550-mtp.dtb arch/arm64/boot/dts/qcom/sm8550-qrd.dtb
On 17/05/2023 04:18, Konrad Dybcio wrote: > SM8550 (LLCCv4.1) has 4 register regions, this was not described > between its addition and the restructurization that happened in > the commit referenced in the fixes tag. > > Fix it. > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 17.05.2023 07:44, Manivannan Sadhasivam wrote: > On Wed, May 17, 2023 at 04:18:49AM +0200, Konrad Dybcio wrote: >> SM8550 (LLCCv4.1) has 4 register regions, this was not described >> between its addition and the restructurization that happened in >> the commit referenced in the fixes tag. >> >> Fix it. >> >> Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") > > I'm not sure if the Fixes tag should point to the patch adding SM8550 support or > the restructuring patch. Right.. I wanted to add *some* fixes tag (clearly a bugfix) and decided this one (and the one in patch 2) were the least bad options, as the cleanup landed after/parallel to 8550 introduction. Konrad > >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > But the change LGTM! > > Acked-by: Manivannan Sadhasivam <mani@kernel.org> > > - Mani > >> --- >> Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> index d8b91944180a..44892aa589fd 100644 >> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml >> @@ -129,6 +129,7 @@ allOf: >> - qcom,sm8250-llcc >> - qcom,sm8350-llcc >> - qcom,sm8450-llcc >> + - qcom,sm8550-llcc >> then: >> properties: >> reg: >> >> -- >> 2.40.1 >> >
diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml index d8b91944180a..44892aa589fd 100644 --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml @@ -129,6 +129,7 @@ allOf: - qcom,sm8250-llcc - qcom,sm8350-llcc - qcom,sm8450-llcc + - qcom,sm8550-llcc then: properties: reg:
SM8550 (LLCCv4.1) has 4 register regions, this was not described between its addition and the restructurization that happened in the commit referenced in the fixes tag. Fix it. Fixes: 43aa006e074c ("dt-bindings: arm: msm: Fix register regions used for LLCC banks") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 1 + 1 file changed, 1 insertion(+)