| Message ID | 20230516083432.18579-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2] dt-bindings: usb: usb251xb: correct swap-dx-lanes type to uint32 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 0 errors, 1 warnings, 8 lines checked |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 5/16/23 10:34, Krzysztof Kozlowski wrote: > The "swap-dx-lanes" was never described as uint8 in original TXT > bindings and Linux driver expects uint32. Fix the type to match Linux > driver expectation. > > Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Marek Vasut <marex@denx.de> Thanks
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote: > The "swap-dx-lanes" was never described as uint8 in original TXT > bindings and Linux driver expects uint32. Fix the type to match Linux > driver expectation. > > Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> LGTM. Please feel free to add Reviewed-by: Richard Leitner <richard.leitner@linux.dev>
On Tue, May 16, 2023 at 10:34:32AM +0200, Krzysztof Kozlowski wrote: > The "swap-dx-lanes" was never described as uint8 in original TXT > bindings and Linux driver expects uint32. Fix the type to match Linux > driver expectation. > > Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/usb/usb251xb.yaml b/Documentation/devicetree/bindings/usb/usb251xb.yaml index 4d1530816817..ac5b99710332 100644 --- a/Documentation/devicetree/bindings/usb/usb251xb.yaml +++ b/Documentation/devicetree/bindings/usb/usb251xb.yaml @@ -231,7 +231,7 @@ properties: power-on sequence to a port until the port has adequate power. swap-dx-lanes: - $ref: /schemas/types.yaml#/definitions/uint8-array + $ref: /schemas/types.yaml#/definitions/uint32-array description: | Specifies the ports which will swap the differential-pair (D+/D-), default is not-swapped.
The "swap-dx-lanes" was never described as uint8 in original TXT bindings and Linux driver expects uint32. Fix the type to match Linux driver expectation. Fixes: fff61d4ccf3d ("dt-bindings: usb: usb251xb: Convert to YAML schema") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. Correct commit msg typo (Marek) Cc: marex@denx.de Cc: mike.looijmans@topic.nl --- Documentation/devicetree/bindings/usb/usb251xb.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)