| Message ID | 20230514074731.70614-2-rudi@heitbaum.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Bluetooth: btrtl: Add support for RTL8822BS | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On Sun, 14 May 2023 07:47:29 +0000, Rudi Heitbaum wrote: > Add compatible string for RTL8822BS for existing Realtek Bluetooth > driver. > > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> > --- > .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed: [{'enum': ['realtek,rtl8821cs-bt']}, {'const': ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt']}] is not of type 'object' ['realtek,rtl8822bs-bt', 'realtek,rtl8822cs-bt'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 167, in <module> sg.check_trees(filename, testtree) ... File "/usr/lib/python3.10/sre_parse.py", line 599, in _parse raise source.error(msg, len(this) + 1 + len(that)) re.error: bad character range s-b at position 18 Note: You even broke the dtschema :) See https://patchwork.ozlabs.org/patch/1781021 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 14/05/2023 09:47, Rudi Heitbaum wrote: > Add compatible string for RTL8822BS for existing Realtek Bluetooth > driver. > > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> > --- > .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 8cc2b9924680..d2103931fc1c 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -4,16 +4,16 @@ > $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth > +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS Bluetooth > > maintainers: > - Vasily Khoruzhick <anarsoul@gmail.com> > - Alistair Francis <alistair@alistair23.me> > > description: > - RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part > - is connected over SDIO, while BT is connected over serial. It speaks > - H5 protocol with few extra commands to upload firmware and change > + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS is a WiFi + BT chip. > + WiFi part is connected over SDIO, while BT is connected over serial. It > + speaks H5 protocol with few extra commands to upload firmware and change > module speed. > > properties: > @@ -23,11 +23,14 @@ properties: > - realtek,rtl8723bs-bt > - realtek,rtl8723cs-bt > - realtek,rtl8723ds-bt > + - realtek,rtl8822bs-bt > - realtek,rtl8822cs-bt > - items: > - enum: > - realtek,rtl8821cs-bt > - - const: realtek,rtl8822cs-bt > + - const: > + - realtek,rtl8822bs-bt > + - realtek,rtl8822cs-bt This won't work, wasn't tested and does not actually make sense. Depending on your goal this could be added to the enum above... or anything else. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 8cc2b9924680..d2103931fc1c 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -4,16 +4,16 @@ $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS Bluetooth maintainers: - Vasily Khoruzhick <anarsoul@gmail.com> - Alistair Francis <alistair@alistair23.me> description: - RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part - is connected over SDIO, while BT is connected over serial. It speaks - H5 protocol with few extra commands to upload firmware and change + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822BS/RTL8822CS is a WiFi + BT chip. + WiFi part is connected over SDIO, while BT is connected over serial. It + speaks H5 protocol with few extra commands to upload firmware and change module speed. properties: @@ -23,11 +23,14 @@ properties: - realtek,rtl8723bs-bt - realtek,rtl8723cs-bt - realtek,rtl8723ds-bt + - realtek,rtl8822bs-bt - realtek,rtl8822cs-bt - items: - enum: - realtek,rtl8821cs-bt - - const: realtek,rtl8822cs-bt + - const: + - realtek,rtl8822bs-bt + - realtek,rtl8822cs-bt device-wake-gpios: maxItems: 1
Add compatible string for RTL8822BS for existing Realtek Bluetooth driver. Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> --- .../devicetree/bindings/net/realtek-bluetooth.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)