| Message ID | 20230510184305.v2.1.I417093ddcea282be479f10a37147d1935a9050b7@changeid |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2] dt-bindings: rcc: stm32: Sync with u-boot copy for STM32MP13 SoC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success |
On Wed, May 10, 2023 at 06:51:40PM +0200, Patrick Delaunay wrote: > Minor cosmetic change, aligned with files in U-Boot: > - change obsolete SPDX id : GPL-2.0+ and use the same license > GPL-2.0-only for the 2 files > - use correct mail address gabriel.fernandez@foss.st.com > - remove extra space Rob's comments on v1 were about $subject, which you've fixed, although the second prefix is a bit odd (I assume since you're changing clock and reset headers) and about the change in license to "or-later" for the resets header, which you've changed too, so... > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > Changes in v2: > - Change title "Fix STM32MP13 include file" > - Use the same license for the 2 files GPL-2.0-only as recommended > to avoid check-patch issue on next > > include/dt-bindings/clock/stm32mp13-clks.h | 6 +++--- > include/dt-bindings/reset/stm32mp13-resets.h | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/dt-bindings/clock/stm32mp13-clks.h b/include/dt-bindings/clock/stm32mp13-clks.h > index 02befd25edce..0bd7b54c65ff 100644 > --- a/include/dt-bindings/clock/stm32mp13-clks.h > +++ b/include/dt-bindings/clock/stm32mp13-clks.h > @@ -1,7 +1,7 @@ > -/* SPDX-License-Identifier: GPL-2.0+ or BSD-3-Clause */ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */ ...since Gabriel does appear to be the only author of this file: Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On 5/10/23 19:02, Conor Dooley wrote: > On Wed, May 10, 2023 at 06:51:40PM +0200, Patrick Delaunay wrote: >> Minor cosmetic change, aligned with files in U-Boot: >> - change obsolete SPDX id : GPL-2.0+ and use the same license >> GPL-2.0-only for the 2 files >> - use correct mail address gabriel.fernandez@foss.st.com >> - remove extra space > Rob's comments on v1 were about $subject, which you've fixed, although > the second prefix is a bit odd (I assume since you're changing clock and > reset headers) and about the change in license to "or-later" for the > resets header, which you've changed too, so... >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> Changes in v2: >> - Change title "Fix STM32MP13 include file" >> - Use the same license for the 2 files GPL-2.0-only as recommended >> to avoid check-patch issue on next >> >> include/dt-bindings/clock/stm32mp13-clks.h | 6 +++--- >> include/dt-bindings/reset/stm32mp13-resets.h | 4 ++-- >> 2 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/include/dt-bindings/clock/stm32mp13-clks.h b/include/dt-bindings/clock/stm32mp13-clks.h >> index 02befd25edce..0bd7b54c65ff 100644 >> --- a/include/dt-bindings/clock/stm32mp13-clks.h >> +++ b/include/dt-bindings/clock/stm32mp13-clks.h >> @@ -1,7 +1,7 @@ >> -/* SPDX-License-Identifier: GPL-2.0+ or BSD-3-Clause */ >> +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */ > ...since Gabriel does appear to be the only author of this file: > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. Hi Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com> Thanks Gabriel
On Wed, 10 May 2023 18:51:40 +0200, Patrick Delaunay wrote: > Minor cosmetic change, aligned with files in U-Boot: > - change obsolete SPDX id : GPL-2.0+ and use the same license > GPL-2.0-only for the 2 files > - use correct mail address gabriel.fernandez@foss.st.com > - remove extra space > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > Changes in v2: > - Change title "Fix STM32MP13 include file" > - Use the same license for the 2 files GPL-2.0-only as recommended > to avoid check-patch issue on next > > include/dt-bindings/clock/stm32mp13-clks.h | 6 +++--- > include/dt-bindings/reset/stm32mp13-resets.h | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
Quoting Patrick Delaunay (2023-05-10 09:51:40) > Minor cosmetic change, aligned with files in U-Boot: > - change obsolete SPDX id : GPL-2.0+ and use the same license > GPL-2.0-only for the 2 files > - use correct mail address gabriel.fernandez@foss.st.com > - remove extra space > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- Applied to clk-next
diff --git a/include/dt-bindings/clock/stm32mp13-clks.h b/include/dt-bindings/clock/stm32mp13-clks.h index 02befd25edce..0bd7b54c65ff 100644 --- a/include/dt-bindings/clock/stm32mp13-clks.h +++ b/include/dt-bindings/clock/stm32mp13-clks.h @@ -1,7 +1,7 @@ -/* SPDX-License-Identifier: GPL-2.0+ or BSD-3-Clause */ +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */ /* * Copyright (C) STMicroelectronics 2020 - All Rights Reserved - * Author: Gabriel Fernandez <gabriel.fernandez@st.com> for STMicroelectronics. + * Author: Gabriel Fernandez <gabriel.fernandez@foss.st.com> for STMicroelectronics. */ #ifndef _DT_BINDINGS_STM32MP13_CLKS_H_ @@ -64,7 +64,7 @@ #define CK_MCO1 38 #define CK_MCO2 39 -/* IP clocks */ +/* IP clocks */ #define SYSCFG 40 #define VREF 41 #define DTS 42 diff --git a/include/dt-bindings/reset/stm32mp13-resets.h b/include/dt-bindings/reset/stm32mp13-resets.h index 934864e90da6..ecb37c7ddde1 100644 --- a/include/dt-bindings/reset/stm32mp13-resets.h +++ b/include/dt-bindings/reset/stm32mp13-resets.h @@ -1,7 +1,7 @@ -/* SPDX-License-Identifier: GPL-2.0 or BSD-3-Clause */ +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-3-Clause */ /* * Copyright (C) STMicroelectronics 2018 - All Rights Reserved - * Author: Gabriel Fernandez <gabriel.fernandez@st.com> for STMicroelectronics. + * Author: Gabriel Fernandez <gabriel.fernandez@foss.st.com> for STMicroelectronics. */ #ifndef _DT_BINDINGS_STM32MP13_RESET_H_
Minor cosmetic change, aligned with files in U-Boot: - change obsolete SPDX id : GPL-2.0+ and use the same license GPL-2.0-only for the 2 files - use correct mail address gabriel.fernandez@foss.st.com - remove extra space Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- Changes in v2: - Change title "Fix STM32MP13 include file" - Use the same license for the 2 files GPL-2.0-only as recommended to avoid check-patch issue on next include/dt-bindings/clock/stm32mp13-clks.h | 6 +++--- include/dt-bindings/reset/stm32mp13-resets.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-)