| Message ID | 20230510112347.3766247-3-himanshu.bhavani@siliconsignals.io |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | arm64: dts: Add initial support for Emtop SOM IMX8MM | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/patch-applied | success | |
| robh/dt-meta-schema | fail | build log |
On 10/05/2023 13:23, Himanshu Bhavani wrote: > Add entries to the list of imx8mm boards denoting > the Emtop SOM from Emtop. > > Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 442ce8f4d675..06eb2c790f90 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -884,6 +884,7 @@ properties: > - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit > - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board > - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC > + - emtop,imx8mm-emtop # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM No real improvements. Still not change in compatible - neither naming nor additional compatible. Instead of adding some random changes, please describe in commit msg what is this exactly and then use compatibles matching it. You already got two times the same comment that board called "emtop" so the same as vendor "emtop" looks wrong. You never responded to these comments. Don't ignore feedbacks, but either respond or implement them. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 442ce8f4d675..06eb2c790f90 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -884,6 +884,7 @@ properties: - beacon,imx8mm-beacon-kit # i.MX8MM Beacon Development Kit - boundary,imx8mm-nitrogen8mm # i.MX8MM Nitrogen Board - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC + - emtop,imx8mm-emtop # i.MX8MM Emtop SOM-IMX8MMLPD4 SoM - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board - fsl,imx8mm-evk # i.MX8MM EVK Board
Add entries to the list of imx8mm boards denoting the Emtop SOM from Emtop. Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io> --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+)